Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Unified Diff: src/compiler/bytecode-graph-builder.h

Issue 2263253002: [interpreter] Make the binary op with Smi bytecode handlers collect type feedback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix some interpreter tests. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/bytecode-graph-builder.h
diff --git a/src/compiler/bytecode-graph-builder.h b/src/compiler/bytecode-graph-builder.h
index 266bfb4a5a873ac2aa911b5e46a347adeb01c743..b938dfad731a6041930f40e92749f5f7830066d4 100644
--- a/src/compiler/bytecode-graph-builder.h
+++ b/src/compiler/bytecode-graph-builder.h
@@ -137,11 +137,7 @@ class BytecodeGraphBuilder {
// Helper function to create binary operation hint from the recorded
// type feedback.
- BinaryOperationHint GetBinaryOperationHint();
-
- // Helper function to create an binary operation hint from the recorded
- // type feedback in Inc/Dec handlers.
- BinaryOperationHint GetBinaryOperationHintForIncDec();
+ BinaryOperationHint GetBinaryOperationHint(int index);
rmcilroy 2016/08/23 10:28:53 nit - operand_index
epertoso 2016/08/23 13:24:28 Done.
// Control flow plumbing.
void BuildJump();
@@ -262,6 +258,10 @@ class BytecodeGraphBuilder {
// Control nodes that exit the function body.
ZoneVector<Node*> exit_controls_;
+ static int const kBinaryOperationHintIndex = 1;
+ static int const kCountOperationHintIndex = 0;
+ static int const kBinaryOperationSmiHintIndex = 2;
+
DISALLOW_COPY_AND_ASSIGN(BytecodeGraphBuilder);
};

Powered by Google App Engine
This is Rietveld 408576698