Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2263243002: predictors: Store protobufs in the database. (Closed)

Created:
4 years, 4 months ago by Benoit L
Modified:
4 years, 4 months ago
CC:
chromium-reviews, shishir+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Store protobufs in the database. This is the first step in the conversion of the database to a protocol buffer based storage format. This introduces a protocol buffer based format for storage. A forthcoming CL will remove ResourceRow. BUG=631966 Committed: https://crrev.com/60cd6e859b9f557d2312f5bf532f6aec5f284980 Cr-Commit-Position: refs/heads/master@{#413716}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -142 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 2 chunks +1 line, -3 lines 0 comments Download
A chrome/browser/predictors/resource_prefetch_predictor.proto View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.h View 1 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.cc View 1 2 15 chunks +101 lines, -88 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables_unittest.cc View 1 2 1 chunk +11 lines, -10 lines 0 comments Download
M tools/resource_prefetch_predictor/prefetch_predictor_tool.py View 3 chunks +14 lines, -37 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
Benoit L
4 years, 4 months ago (2016-08-22 14:42:15 UTC) #2
pasko
overall looks good, one question about the tool below https://codereview.chromium.org/2263243002/diff/20001/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/2263243002/diff/20001/chrome/browser/BUILD.gn#newcode992 chrome/browser/BUILD.gn:992: ...
4 years, 4 months ago (2016-08-22 15:51:28 UTC) #9
Benoit L
Thanks! https://codereview.chromium.org/2263243002/diff/20001/chrome/browser/BUILD.gn File chrome/browser/BUILD.gn (right): https://codereview.chromium.org/2263243002/diff/20001/chrome/browser/BUILD.gn#newcode992 chrome/browser/BUILD.gn:992: if (!is_ios) { On 2016/08/22 15:51:28, pasko wrote: ...
4 years, 4 months ago (2016-08-23 09:46:05 UTC) #12
pasko
lgtm, agreed that the output of the tool makes sense
4 years, 4 months ago (2016-08-23 11:41:20 UTC) #15
Benoit L
+jochen@ for OWNERS review of the BUILD.gn change. PTAL, thanks!
4 years, 4 months ago (2016-08-23 11:45:07 UTC) #16
Benoit L
+jochen@ for OWNERS review of the BUILD.gn change. PTAL, thanks!
4 years, 4 months ago (2016-08-23 11:46:03 UTC) #18
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-23 12:00:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263243002/40001
4 years, 4 months ago (2016-08-23 12:01:03 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-23 12:04:42 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 12:06:22 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/60cd6e859b9f557d2312f5bf532f6aec5f284980
Cr-Commit-Position: refs/heads/master@{#413716}

Powered by Google App Engine
This is Rietveld 408576698