[WONT COMMIT] WebSocket: Remove WorkerThread::terminated() call

WebSocket: Remove WorkerThread::terminated() call

WorkerThread::terminated() should be removed because it exposes an internal
state of WorkerThread. Instead, clients of WorkerThread should check a thread
state by WorkerThreadLifecycleObserver.

In this CL, WorkerWebSocketChannel::Peer on main thread observes worker thread
termination and notifies WorkerWebSocketChannel::Bridge on worker thread via
WebSocketChannelSyncHelper.

BUG=639153

[nhiroki, 2016-08-22 13:38:18]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 13:38:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-08-22 13:44:09]

Description was changed from

==========
WebSocket: Remove WorkerThread::terminated() call

WorkerThread::terminated() should be removed because it exposes an internal
state of WorkerThread. Clients of WorkerThread should check a thread state not
by WorkerThread::terminated() but by WorkerThreadLifecycleObserver.

BUG=639153
==========

to

==========
WebSocket: Remove WorkerThread::terminated() call

WorkerThread::terminated() should be removed because it exposes an internal
state of WorkerThread. Instead, clients of WorkerThread should check a thread
state by WorkerThreadLifecycleObserver.

In this CL, WorkerWebSocketChannel::Peer on main thread observes worker thread
termination and notifies WorkerWebSocketChannel::Bridge on worker thread via
WebSocketChannelSyncHelper.

BUG=639153
==========

[nhiroki, 2016-08-22 13:44:15]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 13:44:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 16:08:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 16:08:42]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nhiroki, 2016-08-22 22:43:22]

nhiroki@chromium.org changed reviewers:
+ yhirano@chromium.org

[nhiroki, 2016-08-22 22:43:23]

PTAL, thanks!

[haraken, 2016-08-22 23:49:42]

LGTM on my side.

[yhirano, 2016-08-23 02:27:15]

https://codereview.chromium.org/2263173002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
(right):

https://codereview.chromium.org/2263173002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp:382:
m_syncHelper->setWorkerThreadTerminated(true);
I think this can be called after m_syncHelper->signalWorkerThread() is called,
which violates a WebSocketChannelSyncHelper assumption.

[nhiroki, 2016-08-24 08:38:16]

Let me close this CL in favor of https://codereview.chromium.org/2271133002/

[nhiroki, 2016-08-24 08:38:30]

Description was changed from

==========
WebSocket: Remove WorkerThread::terminated() call

WorkerThread::terminated() should be removed because it exposes an internal
state of WorkerThread. Instead, clients of WorkerThread should check a thread
state by WorkerThreadLifecycleObserver.

In this CL, WorkerWebSocketChannel::Peer on main thread observes worker thread
termination and notifies WorkerWebSocketChannel::Bridge on worker thread via
WebSocketChannelSyncHelper.

BUG=639153
==========

to

==========
WebSocket: Remove WorkerThread::terminated() call

WorkerThread::terminated() should be removed because it exposes an internal
state of WorkerThread. Instead, clients of WorkerThread should check a thread
state by WorkerThreadLifecycleObserver.

In this CL, WorkerWebSocketChannel::Peer on main thread observes worker thread
termination and notifies WorkerWebSocketChannel::Bridge on worker thread via
WebSocketChannelSyncHelper.

BUG=639153
==========