Chromium Code Reviews

Issue 2263163002: [turbofan] mark Float64(Max|Min) as associative and commutative. (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] mark Float64(Max|Min) as associative and commutative. Now that -0.0 and 0.0 are ordered by Float64Max and Float64Min, these two operator are both associative and commutative for all numbers. The operators would not be associative and commutative for NaNs, but neither JavaScript nor WebAssembly distinguish between NaNs nowadays. R=jarin@chromium.org Committed: https://crrev.com/10e7ccfbd4199b8d39cd526e7a675b21291aca65 Cr-Commit-Position: refs/heads/master@{#38791}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+2 lines, -2 lines)
M src/compiler/machine-operator.cc View 1 chunk +2 lines, -2 lines 0 comments

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 3 months ago (2016-08-22 13:28:29 UTC) #1
Jarin
lgtm
4 years, 3 months ago (2016-08-22 14:25:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263163002/1
4 years, 3 months ago (2016-08-22 15:23:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-22 15:26:11 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-22 15:26:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10e7ccfbd4199b8d39cd526e7a675b21291aca65
Cr-Commit-Position: refs/heads/master@{#38791}

Powered by Google App Engine