Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2263123002: Find the last outer eval scope to check in fullcodegen rather than scope analysis (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Find the last outer eval scope to check in fullcodegen rather than scope analysis This is the only user of outer_scope_calls_sloppy_eval. Inlining it simplifies scope analysis. BUG=v8:5209 Committed: https://crrev.com/8f8a906751719ae8ef811fe8fd787ba2bc7c19fd Cr-Commit-Position: refs/heads/master@{#38779}

Patch Set 1 #

Patch Set 2 : Address comments #

Patch Set 3 : Add ports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -184 lines) Patch
M src/ast/scopes.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/ast/scopes.cc View 1 7 chunks +19 lines, -24 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 1 chunk +13 lines, -17 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 1 chunk +13 lines, -17 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 1 chunk +13 lines, -17 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 1 chunk +13 lines, -17 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 1 chunk +13 lines, -17 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 2 1 chunk +13 lines, -17 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 2 1 chunk +13 lines, -17 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +13 lines, -17 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 2 1 chunk +13 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-22 11:14:20 UTC) #2
Michael Starzinger
LGTM (modulo missing architecture ports).
4 years, 4 months ago (2016-08-22 11:22:57 UTC) #3
Toon Verwaest
Added ports
4 years, 4 months ago (2016-08-22 11:23:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263123002/40001
4 years, 4 months ago (2016-08-22 11:26:22 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-22 11:50:30 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 11:50:57 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f8a906751719ae8ef811fe8fd787ba2bc7c19fd
Cr-Commit-Position: refs/heads/master@{#38779}

Powered by Google App Engine
This is Rietveld 408576698