Use testharness.js instead of js-test.js in OffscreenCanvas tests.

Use testharness.js instead of js-test.js in OffscreenCanvas tests.

Change test code to replace js-test.js functions with
testharness.js asserts for OffscreenCanvas-currentColor
and OffscreenCanvas-invalid-args tests. Remove the expectation
files as they are not necessary now.

BUG=639732

[sivag, 2016-08-22 10:24:43]

Description was changed from

==========
Use testharness.js instead of js-test.js in OffscreenCanvas tests.

Change test code to replace js-test.js functions with
testharness.js asserts for OffscreenCanvas-currentColor
and OffscreenCanvas-invalid-args tests. Remove the expectation
files as they are not necessary now.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in OffscreenCanvas tests.

Change test code to replace js-test.js functions with
testharness.js asserts for OffscreenCanvas-currentColor
and OffscreenCanvas-invalid-args tests. Remove the expectation
files as they are not necessary now.

BUG=639732
==========

[sivag, 2016-08-22 10:24:43]

siva.gunturi@samsung.com changed reviewers:
+ fs@opera.com, junov@chromium.org, srirama.m@samsung.com

[sivag, 2016-08-22 10:26:09]

@junov, fs, ptal..

[fs, 2016-08-22 10:50:12]

https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html
(right):

https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:22:
assert_throws(TypeError(), function() { new OffscreenCanvas(-1, -1); });
new TypeError()

https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:36:
assert_throws(TypeError(), function() { canvas2.height = -obj; });
Added negation (which wasn't in the original.)

[sivag, 2016-08-22 12:57:47]

On 2016/08/22 10:50:12, fs wrote:
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> File
> third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html
> (right):
> 
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:22:
> assert_throws(TypeError(), function() { new OffscreenCanvas(-1, -1); });
> new TypeError()
> 
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:36:
> assert_throws(TypeError(), function() { canvas2.height = -obj; });
> Added negation (which wasn't in the original.)

I am facing some issue as it shows a wrong issue id while uploading like below,
Issue number: -2031854293 (https://codereview.chromium.org/-2031854293).

even after resetting the issue number it remains same , not sure what can be the
issue.

[fs, 2016-08-22 13:17:32]

On 2016/08/22 at 12:57:47, siva.gunturi wrote:
> On 2016/08/22 10:50:12, fs wrote:
> >
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> > File
> > third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html
> > (right):
> > 
> >
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> >
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:22:
> > assert_throws(TypeError(), function() { new OffscreenCanvas(-1, -1); });
> > new TypeError()
> > 
> >
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> >
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:36:
> > assert_throws(TypeError(), function() { canvas2.height = -obj; });
> > Added negation (which wasn't in the original.)
> 
> I am facing some issue as it shows a wrong issue id while uploading like
below,
> Issue number: -2031854293 (https://codereview.chromium.org/-2031854293).
> 
> even after resetting the issue number it remains same , not sure what can be
the issue.

Never seen that happen before. If you can reproduce you should probably file a
Infra-bug (Infra>CodeReview>Rietveld I'm guessing.)

[Justin Novosad, 2016-08-22 14:26:22]

https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html
(right):

https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html:2:
<title>Test that the fill and stroke style attribute yield opaque black when set
to 'currentcolor' on an OffscreenCanvasRenderingContext2D.</title>
attributes (plural)

[sivag, 2016-08-22 15:39:27]

On 2016/08/22 13:17:32, fs wrote:
> On 2016/08/22 at 12:57:47, siva.gunturi wrote:
> > On 2016/08/22 10:50:12, fs wrote:
> > >
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> > > File
> > >
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html
> > > (right):
> > > 
> > >
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> > >
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:22:
> > > assert_throws(TypeError(), function() { new OffscreenCanvas(-1, -1); });
> > > new TypeError()
> > > 
> > >
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> > >
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:36:
> > > assert_throws(TypeError(), function() { canvas2.height = -obj; });
> > > Added negation (which wasn't in the original.)
> > 
> > I am facing some issue as it shows a wrong issue id while uploading like
> below,
> > Issue number: -2031854293 (https://codereview.chromium.org/-2031854293).
> > 
> > even after resetting the issue number it remains same , not sure what can be
> the issue.
> 
> Never seen that happen before. If you can reproduce you should probably file a
> Infra-bug (Infra>CodeReview>Rietveld I'm guessing.)

Sure i will file a bug for this.

[sivag, 2016-08-22 15:40:14]

https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html
(right):

https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html:2:
<title>Test that the fill and stroke style attribute yield opaque black when set
to 'currentcolor' on an OffscreenCanvasRenderingContext2D.</title>
On 2016/08/22 14:26:22, Justin Novosad wrote:
> attributes (plural)

Done.

I have taken care of this in the other patch.

https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html
(right):

https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:22:
assert_throws(TypeError(), function() { new OffscreenCanvas(-1, -1); });
On 2016/08/22 10:50:12, fs wrote:
> new TypeError()

Done.

https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:36:
assert_throws(TypeError(), function() { canvas2.height = -obj; });
On 2016/08/22 10:50:12, fs wrote:
> Added negation (which wasn't in the original.)

Done.

[Justin Novosad, 2016-08-22 17:50:58]

I think you forgot to upload the new patchset

[sivag, 2016-08-22 18:16:18]

On 2016/08/22 17:50:58, Justin Novosad wrote:
> I think you forgot to upload the new patchset

Sorry for the confusion, As i mentioned this issue
has a problem while uploading, so i added the new 
patchset here https://codereview.chromium.org/2264953003/

[sivag, 2016-08-23 06:28:28]

On 2016/08/22 13:17:32, fs wrote:
> On 2016/08/22 at 12:57:47, siva.gunturi wrote:
> > On 2016/08/22 10:50:12, fs wrote:
> > >
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> > > File
> > >
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html
> > > (right):
> > > 
> > >
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> > >
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:22:
> > > assert_throws(TypeError(), function() { new OffscreenCanvas(-1, -1); });
> > > new TypeError()
> > > 
> > >
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> > >
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:36:
> > > assert_throws(TypeError(), function() { canvas2.height = -obj; });
> > > Added negation (which wasn't in the original.)
> > 
> > I am facing some issue as it shows a wrong issue id while uploading like
> below,
> > Issue number: -2031854293 (https://codereview.chromium.org/-2031854293).
> > 
> > even after resetting the issue number it remains same , not sure what can be
> the issue.
> 
> Never seen that happen before. If you can reproduce you should probably file a
> Infra-bug (Infra>CodeReview>Rietveld I'm guessing.)

filed a bug for this
https://bugs.chromium.org/p/chromium/issues/detail?id=640115