Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2263113003: Use testharness.js instead of js-test.js in OffscreenCanvas tests. (Closed)

Created:
4 years, 4 months ago by sivag
Modified:
4 years, 3 months ago
Reviewers:
Srirama, fs, Justin Novosad
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js instead of js-test.js in OffscreenCanvas tests. Change test code to replace js-test.js functions with testharness.js asserts for OffscreenCanvas-currentColor and OffscreenCanvas-invalid-args tests. Remove the expectation files as they are not necessary now. BUG=639732

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -84 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html View 1 chunk +13 lines, -13 lines 2 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html View 1 chunk +36 lines, -37 lines 4 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
sivag
@junov, fs, ptal..
4 years, 4 months ago (2016-08-22 10:26:09 UTC) #3
fs
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html File third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html (right): https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html#newcode22 third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:22: assert_throws(TypeError(), function() { new OffscreenCanvas(-1, -1); }); new TypeError() ...
4 years, 4 months ago (2016-08-22 10:50:12 UTC) #4
sivag
On 2016/08/22 10:50:12, fs wrote: > https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html > File > third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html > (right): > > ...
4 years, 4 months ago (2016-08-22 12:57:47 UTC) #5
fs
On 2016/08/22 at 12:57:47, siva.gunturi wrote: > On 2016/08/22 10:50:12, fs wrote: > > https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html ...
4 years, 4 months ago (2016-08-22 13:17:32 UTC) #6
Justin Novosad
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html File third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html (right): https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html#newcode2 third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html:2: <title>Test that the fill and stroke style attribute yield ...
4 years, 4 months ago (2016-08-22 14:26:22 UTC) #7
sivag
On 2016/08/22 13:17:32, fs wrote: > On 2016/08/22 at 12:57:47, siva.gunturi wrote: > > On ...
4 years, 4 months ago (2016-08-22 15:39:27 UTC) #8
sivag
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html File third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html (right): https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html#newcode2 third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html:2: <title>Test that the fill and stroke style attribute yield ...
4 years, 4 months ago (2016-08-22 15:40:14 UTC) #9
Justin Novosad
I think you forgot to upload the new patchset
4 years, 4 months ago (2016-08-22 17:50:58 UTC) #10
sivag
On 2016/08/22 17:50:58, Justin Novosad wrote: > I think you forgot to upload the new ...
4 years, 4 months ago (2016-08-22 18:16:18 UTC) #11
sivag
4 years, 4 months ago (2016-08-23 06:28:28 UTC) #12
On 2016/08/22 13:17:32, fs wrote:
> On 2016/08/22 at 12:57:47, siva.gunturi wrote:
> > On 2016/08/22 10:50:12, fs wrote:
> > >
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> > > File
> > >
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html
> > > (right):
> > > 
> > >
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> > >
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:22:
> > > assert_throws(TypeError(), function() { new OffscreenCanvas(-1, -1); });
> > > new TypeError()
> > > 
> > >
>
https://codereview.chromium.org/2263113003/diff/1/third_party/WebKit/LayoutTe...
> > >
>
third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html:36:
> > > assert_throws(TypeError(), function() { canvas2.height = -obj; });
> > > Added negation (which wasn't in the original.)
> > 
> > I am facing some issue as it shows a wrong issue id while uploading like
> below,
> > Issue number: -2031854293 (https://codereview.chromium.org/-2031854293).
> > 
> > even after resetting the issue number it remains same , not sure what can be
> the issue.
> 
> Never seen that happen before. If you can reproduce you should probably file a
> Infra-bug (Infra>CodeReview>Rietveld I'm guessing.)

filed a bug for this
https://bugs.chromium.org/p/chromium/issues/detail?id=640115

Powered by Google App Engine
This is Rietveld 408576698