Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2263103003: Add trooper documentation for CT bots and for iOS "the service is invalid" (Closed)

Created:
4 years, 4 months ago by rmistry
Modified:
4 years, 3 months ago
Reviewers:
borenet, stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add trooper documentation for CT bots and for iOS "the service is invalid" BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263103003 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2263103003 Committed: https://skia.googlesource.com/skia/+/674b92522765183ae14c06e245f9128bd8781d54

Patch Set 1 : Initial upload #

Patch Set 2 : Minor fix #

Total comments: 2

Patch Set 3 : Remove milo link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M site/dev/sheriffing/trooper.md View 1 2 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
rmistry
4 years, 4 months ago (2016-08-22 14:08:31 UTC) #3
stephana
LGTM with one question Some parts are better reviewed by borenet https://codereview.chromium.org/2263103003/diff/20001/site/dev/sheriffing/trooper.md File site/dev/sheriffing/trooper.md (right): ...
4 years, 4 months ago (2016-08-22 15:22:01 UTC) #4
rmistry
https://codereview.chromium.org/2263103003/diff/20001/site/dev/sheriffing/trooper.md File site/dev/sheriffing/trooper.md (right): https://codereview.chromium.org/2263103003/diff/20001/site/dev/sheriffing/trooper.md#newcode119 site/dev/sheriffing/trooper.md:119: - Sometimes iOS builds fail with 'The service is ...
4 years, 3 months ago (2016-08-22 15:58:42 UTC) #5
stephana
On 2016/08/22 15:58:42, rmistry wrote: > https://codereview.chromium.org/2263103003/diff/20001/site/dev/sheriffing/trooper.md > File site/dev/sheriffing/trooper.md (right): > > https://codereview.chromium.org/2263103003/diff/20001/site/dev/sheriffing/trooper.md#newcode119 > ...
4 years, 3 months ago (2016-08-22 16:04:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263103003/40001
4 years, 3 months ago (2016-08-22 19:54:01 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-22 19:54:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/674b92522765183ae14c06e245f9128bd8781d54

Powered by Google App Engine
This is Rietveld 408576698