git cl issue: add --json switch for machine-readable output

git cl issue: add --json switch for machine-readable output

This was requested in https://chromium-review.googlesource.com/c/373499

BUG=none

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/e328cf9c78a02f44b24dfa809284a6e94bcec935

[Paweł Hajdan Jr., 2016-08-22 08:55:53]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 08:56:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Paweł Hajdan Jr., 2016-08-22 09:01:15]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 09:01:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 09:04:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 09:04:10]

Dry run: This issue passed the CQ dry run.

[emso, 2016-08-22 09:19:03]

emso@chromium.org changed reviewers:
+ emso@chromium.org

[emso, 2016-08-22 09:19:04]

lgtm

[tandrii(chromium), 2016-08-22 10:04:30]

tandrii@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-08-22 10:04:31]

good, but missing tests

https://codereview.chromium.org/2263103002/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/2263103002/diff/20001/git_cl.py#newcode3483
git_cl.py:3483: with open(options.json, 'w') as f:
this should be a function for easy testing. Smth like:

def write_json(options.json, result)

then mock it here
https://cs.chromium.org/chromium/tools/depot_tools/tests/git_cl_test.py?q=git...
with lambda being
  lambda f, j: self._mocked_call('write_json', f, j)

and then it's really to add test for this:

def test_xxx():
  self.calls = [
   ...
   ((['write_json', 'out.json', {'issue': 113, ...}],), ''),
  ]
  git_cl.main(['issue', ..])

[tandrii(chromium), 2016-08-22 11:08:26]

Thanks, LGTM!

[Paweł Hajdan Jr., 2016-08-22 11:08:53]

The CQ bit was checked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-08-22 11:08:54]

The patchset sent to the CQ was uploaded after l-g-t-m from emso@chromium.org
Link to the patchset: https://codereview.chromium.org/2263103002/#ps40001
(title: "tests")

[commit-bot: I haz the power, 2016-08-22 11:09:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 11:12:22]

Description was changed from

==========
git cl issue: add --json switch for machine-readable output

This was requested in https://chromium-review.googlesource.com/c/373499

BUG=none
==========

to

==========
git cl issue: add --json switch for machine-readable output

This was requested in https://chromium-review.googlesource.com/c/373499

BUG=none

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e328cf9c78a02f...
==========

[commit-bot: I haz the power, 2016-08-22 11:12:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/e328cf9c78a02f...