Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2263073003: DevTools: Prepare CodeMirrorTextEditor for split into SourcesTextEditor (Closed)

Created:
4 years, 4 months ago by einbinder
Modified:
4 years, 4 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Prepare CodeMirrorTextEditor for split into SourcesTextEditor This is in preperation for CodeMirror-based console BUG=607690 Committed: https://crrev.com/816d433f646b54df4a11dfe3da0736d64a1c9246 Cr-Commit-Position: refs/heads/master@{#413640}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits #

Messages

Total messages: 9 (4 generated)
einbinder
Ptal, First patch about splitting CMTE into CMTE + SourcesTextEditor
4 years, 4 months ago (2016-08-22 20:59:26 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2263073003/diff/1/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js File third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js (right): https://codereview.chromium.org/2263073003/diff/1/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js#newcode939 third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:939: stray line https://codereview.chromium.org/2263073003/diff/1/third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js#newcode954 third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js:954: _mimeTypeModesLoaded: function() { }, ...
4 years, 4 months ago (2016-08-22 22:24:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263073003/20001
4 years, 4 months ago (2016-08-22 22:51:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 02:36:42 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 02:38:31 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/816d433f646b54df4a11dfe3da0736d64a1c9246
Cr-Commit-Position: refs/heads/master@{#413640}

Powered by Google App Engine
This is Rietveld 408576698