android_webview/browser/browser_view_renderer_client.h - Issue 2263043002: android_webview: Let AwContents manage TouchHandleDrawable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer_client.h

Issue 2263043002: android_webview: Let AwContents manage TouchHandleDrawable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use SynchronousCompositorClient Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/browser_view_renderer.cc ('K') | « android_webview/browser/browser_view_renderer.cc ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/browser_view_renderer_client.h

diff --git a/android_webview/browser/browser_view_renderer_client.h b/android_webview/browser/browser_view_renderer_client.h

index ba154b6d31a333d44e05097fb9f3ae200d4922ce..b28dec2f01b9e9bcaa107ae9828fe8b72e2f6640 100644

--- a/android_webview/browser/browser_view_renderer_client.h

+++ b/android_webview/browser/browser_view_renderer_client.h

@@ -9,6 +9,7 @@

#include "ui/gfx/geometry/point.h"

#include "ui/gfx/geometry/size_f.h"

#include "ui/gfx/geometry/vector2d_f.h"

+#include "ui/touch_selection/touch_handle.h"

boliu 2016/08/24 23:35:30 forward declare should be enough here

Jinsuk Kim 2016/08/25 07:32:21 Done.

namespace android_webview {

struct ParentCompositorDrawConstraints;

@@ -46,6 +47,8 @@ class BrowserViewRendererClient {

virtual void DidOverscroll(const gfx::Vector2d& overscroll_delta,

const gfx::Vector2dF& overscroll_velocity) = 0;

+ virtual ui::TouchHandleDrawable* CreateDrawable(float dip_scale) = 0;

protected:

virtual ~BrowserViewRendererClient() {}

};