android_webview/browser/browser_view_renderer.cc - Issue 2263043002: android_webview: Let AwContents manage TouchHandleDrawable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 2263043002: android_webview: Let AwContents manage TouchHandleDrawable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use SynchronousCompositorClient Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/browser_view_renderer.h ('K') | « android_webview/browser/browser_view_renderer.h ('k') | android_webview/browser/browser_view_renderer_client.h » ('j') | android_webview/browser/browser_view_renderer_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/browser_view_renderer.cc

diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc

index 63e2f5cefaf497af9d25029a2336dd7a74e26aa2..c012c092f0691069fa051835d1b1bfe500baf3e1 100644

--- a/android_webview/browser/browser_view_renderer.cc

+++ b/android_webview/browser/browser_view_renderer.cc

@@ -700,6 +700,11 @@ void BrowserViewRenderer::DidOverscroll(

client_->DidOverscroll(rounded_overscroll_delta, fling_velocity_pixels);

}

+ui::TouchHandleDrawable* BrowserViewRenderer::CreateDrawable() {

+ CHECK_GT(dip_scale_, 0.f);

boliu 2016/08/24 23:35:30 hmm, curious, does this really need to be a releas

Jinsuk Kim 2016/08/25 07:32:21 Nope, meant to use DCHECK_GT like in other places

+ return client_->CreateDrawable(dip_scale_);

void BrowserViewRenderer::PostInvalidate(

content::SynchronousCompositor* compositor) {

TRACE_EVENT_INSTANT0("android_webview", "BrowserViewRenderer::PostInvalidate",