Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 2263043002: android_webview: Let AwContents manage TouchHandleDrawable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix build Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 030a0a55bf0a10e9dbe748bc7c357e23b0e7f600..1009072aa8d9daff7d120327238ab822de19f7bd 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -47,6 +47,7 @@ import org.chromium.android_webview.permission.AwGeolocationCallback;
import org.chromium.android_webview.permission.AwPermissionRequest;
import org.chromium.base.LocaleUtils;
import org.chromium.base.Log;
+import org.chromium.base.ObserverList;
import org.chromium.base.ThreadUtils;
import org.chromium.base.TraceEvent;
import org.chromium.base.VisibleForTesting;
@@ -287,6 +288,9 @@ public class AwContents implements SmartClipProvider,
private final AwSettings mSettings;
private final ScrollAccessibilityHelper mScrollAccessibilityHelper;
+ private final ObserverList<PopupTouchHandleDrawable> mTouchHandleDrawables =
+ new ObserverList<>();
+
private boolean mIsPaused;
private boolean mIsViewVisible;
private boolean mIsWindowVisible;
@@ -924,6 +928,9 @@ public class AwContents implements SmartClipProvider,
mAwPdfExporter.setContainerView(mContainerView);
}
mWebContentsDelegate.setContainerView(mContainerView);
+ for (PopupTouchHandleDrawable drawable: mTouchHandleDrawables) {
+ drawable.onContainerViewChanged(newContainerView);
+ }
onContainerViewChanged();
}
@@ -2673,6 +2680,13 @@ public class AwContents implements SmartClipProvider,
mFavicon = bitmap;
}
+ @CalledByNative
+ private long onCreateTouchHandle() {
+ PopupTouchHandleDrawable drawable =
+ PopupTouchHandleDrawable.create(mTouchHandleDrawables, mContentViewCore, mDIPScale);
+ return drawable.getNativeDrawable();
+ }
+
/** Callback for generateMHTML. */
@CalledByNative
private static void generateMHTMLCallback(

Powered by Google App Engine
This is Rietveld 408576698