ui/file_manager/video_player/js/media_controls.js - Issue 2263033002: Let a video resume automatically when changing the playback position after the playback has finished

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/video_player/js/media_controls.js

Issue 2263033002: Let a video resume automatically when changing the playback position after the playback has finished (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/video_player/js/media_controls.js

diff --git a/ui/file_manager/video_player/js/media_controls.js b/ui/file_manager/video_player/js/media_controls.js

index b8a244efca5d5d6b73067d2edcc41c89bc1e9912..95b13d119a0f39efcc4659f77cfdacfa1d03ec4e 100644

--- a/ui/file_manager/video_player/js/media_controls.js

+++ b/ui/file_manager/video_player/js/media_controls.js

@@ -345,6 +345,9 @@ MediaControls.prototype.onProgressChange_ = function(value) {

this.setSeeking_(false);

+ if (this.media_.ended)

fukino 2016/08/22 07:22:01 nit: Please add a comment explaining that we shoul

harukam1 2016/08/22 08:34:03 Acknowledged.

+ this.play();

var current = this.media_.duration * value;

this.media_.currentTime = current;

this.updateTimeLabel_(current);

« no previous file with comments | « no previous file | no next file » | no next file with comments »