Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 2263033002: Let a video resume automatically when changing the playback position after the playback has finished (Closed)

Created:
4 years, 4 months ago by harukam
Modified:
4 years, 4 months ago
Reviewers:
fukino, harukam1
CC:
chromium-reviews, posciak+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let a video resume automatically when changing the playback position after the playback has finished BUG=418441 TEST=manually tested Committed: https://crrev.com/4b974a1a40c855946a0a9ece10aa9647e31d97b1 Cr-Commit-Position: refs/heads/master@{#413424}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Let a video resume automatically when changing the playback position after the playback has finished #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/file_manager/video_player/js/media_controls.js View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
harukam1
PTAL
4 years, 4 months ago (2016-08-22 06:39:03 UTC) #2
fukino
LGTM with a nit. https://codereview.chromium.org/2263033002/diff/1/ui/file_manager/video_player/js/media_controls.js File ui/file_manager/video_player/js/media_controls.js (right): https://codereview.chromium.org/2263033002/diff/1/ui/file_manager/video_player/js/media_controls.js#newcode348 ui/file_manager/video_player/js/media_controls.js:348: if (this.media_.ended) nit: Please add ...
4 years, 4 months ago (2016-08-22 07:22:01 UTC) #3
harukam1
PTAL https://codereview.chromium.org/2263033002/diff/1/ui/file_manager/video_player/js/media_controls.js File ui/file_manager/video_player/js/media_controls.js (right): https://codereview.chromium.org/2263033002/diff/1/ui/file_manager/video_player/js/media_controls.js#newcode348 ui/file_manager/video_player/js/media_controls.js:348: if (this.media_.ended) On 2016/08/22 07:22:01, fukino wrote: > ...
4 years, 4 months ago (2016-08-22 08:34:03 UTC) #4
fukino
still lgtm. Thanks!
4 years, 4 months ago (2016-08-22 08:41:59 UTC) #6
fukino
still lgtm. Thanks!
4 years, 4 months ago (2016-08-22 08:42:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263033002/20001
4 years, 4 months ago (2016-08-22 08:47:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 09:31:26 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 09:34:44 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b974a1a40c855946a0a9ece10aa9647e31d97b1
Cr-Commit-Position: refs/heads/master@{#413424}

Powered by Google App Engine
This is Rietveld 408576698