Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2263013002: [Merge-M53] arc: Add package app list updated event. (Closed)

Created:
4 years, 4 months ago by khmel
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[Merge-M53] arc: Add package app list updated event. This requires to keep state of installed Arc apps when a package gets updated. Before 2 events were issued, package removed and packaged added. First event removes all relevant data from Chrome prefs and this also makes pin disappearing. TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true BUG=639049 BUG=b/30564914 TEST=Manually on device. Pin and position in recent are preserved on package update. Pin and item from app list are removed when packaged is uninstalled. TEST=Extend unit_tests browser_tests Review-Url: https://codereview.chromium.org/2228663003 Cr-Commit-Position: refs/heads/master@{#411194} (cherry picked from commit 500b22fce0a7c794d90d3ddbba5aec93f9e8f9ab)

Patch Set 1 #

Patch Set 2 : resolve browser_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -27 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 5 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 6 chunks +48 lines, -16 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 2 chunks +34 lines, -1 line 0 comments Download
A chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc View 1 1 chunk +194 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/common/app.mojom View 3 chunks +7 lines, -3 lines 0 comments Download
M components/arc/test/fake_app_instance.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/arc/test/fake_app_instance.cc View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263013002/20001
4 years, 4 months ago (2016-08-22 02:33:12 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 02:35:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698