Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2262993002: Fixes deleting history when there is only one item (Closed)

Created:
4 years, 4 months ago by ahmetemirercin
Modified:
4 years, 4 months ago
Reviewers:
calamity
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes removing of single child top level history items. BUG=638549 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3af071ebc6a49ab6e7af9561d92fa5d729407832 Cr-Commit-Position: refs/heads/master@{#413668}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixes removing of single child top level history items. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_list_behavior.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/md_history/history_list_test.js View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
ahmetemirercin
4 years, 4 months ago (2016-08-21 18:49:41 UTC) #4
ahmetemirercin
https://codereview.chromium.org/2262993002/diff/1/chrome/browser/resources/md_history/history_list_behavior.js File chrome/browser/resources/md_history/history_list_behavior.js (right): https://codereview.chromium.org/2262993002/diff/1/chrome/browser/resources/md_history/history_list_behavior.js#newcode178 chrome/browser/resources/md_history/history_list_behavior.js:178: if (array.length == 0 && node.currentPath.indexOf('.') != -1) Returns ...
4 years, 4 months ago (2016-08-21 18:52:34 UTC) #5
calamity
Can you please add a test case to history_list_test.js for this? Thanks.
4 years, 4 months ago (2016-08-22 02:00:20 UTC) #6
ahmetemirercin
4 years, 4 months ago (2016-08-23 01:57:21 UTC) #7
calamity
lgtm
4 years, 4 months ago (2016-08-23 03:27:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262993002/20001
4 years, 4 months ago (2016-08-23 04:07:58 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 05:10:29 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3af071ebc6a49ab6e7af9561d92fa5d729407832 Cr-Commit-Position: refs/heads/master@{#413668}
4 years, 4 months ago (2016-08-23 05:12:38 UTC) #15
ahmetemirercin
4 years, 4 months ago (2016-08-23 17:44:32 UTC) #16
Message was sent while issue was closed.
On 2016/08/23 03:27:54, calamity wrote:
> lgtm

Thanks calamity for your review.

Powered by Google App Engine
This is Rietveld 408576698