Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1968)

Unified Diff: tools/picture_utils.h

Issue 226293002: add explicit filepaths to render_pictures JSON summary (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/PictureRenderer.cpp ('k') | tools/picture_utils.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/picture_utils.h
diff --git a/tools/picture_utils.h b/tools/picture_utils.h
index 4c2f6e546a0ebad1647e8af84b366f7f78a65368..02eee285d030894a2be70ac14e32b978e13214ad 100644
--- a/tools/picture_utils.h
+++ b/tools/picture_utils.h
@@ -24,14 +24,25 @@ namespace sk_tools {
// not be on the GPU.
void force_all_opaque(const SkBitmap& bitmap);
+ /**
+ * Replaces all instances of oldChar with newChar in str.
+ *
+ * TODO: This function appears here and in skimage_main.cpp ;
+ * we should add the implementation to src/core/SkString.cpp, write tests for it,
+ * and remove it from elsewhere.
+ */
+ void replace_char(SkString* str, const char oldChar, const char newChar);
+
// Creates a posix style filepath by concatenating name onto dir with a
// forward slash into path.
+ // TODO(epoger): delete in favor of SkOSPath::SkPathJoin()?
void make_filepath(SkString* path, const SkString&, const SkString& name);
// Returns the last part of the path (file name or leaf directory name)
//
// This basically just looks for a foward slash or backslash (windows
// only).
+ // TODO(epoger): delete in favor of SkOSPath::SkBasename()?
void get_basename(SkString* basename, const SkString& path);
// Returns true if the string ends with %
« no previous file with comments | « tools/PictureRenderer.cpp ('k') | tools/picture_utils.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698