Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/PictureRenderer.h

Issue 226293002: add explicit filepaths to render_pictures JSON summary (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/PictureRenderer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/PictureRenderer.h
diff --git a/tools/PictureRenderer.h b/tools/PictureRenderer.h
index 7c5a9da1f0d2d97f6cb26d02b5edafc8e4f712f5..26bdb7790fa126a760ed43a1d69e547b724fcfe4 100644
--- a/tools/PictureRenderer.h
+++ b/tools/PictureRenderer.h
@@ -44,20 +44,26 @@ class TiledPictureRenderer;
class ImageResultsSummary {
public:
/**
- * Adds this bitmap hash to the summary of results.
+ * Adds this image to the summary of results.
*
- * @param testName name of the test
+ * @param sourceName name of the source file that generated this result
+ * @param fileName relative path to the image output file on local disk
* @param hash hash to store
+ * @param tileNumber if not NULL, ptr to tile number
*/
- void add(const char *testName, uint64_t hash);
+ void add(const char *sourceName, const char *fileName, uint64_t hash,
+ const int *tileNumber=NULL);
/**
- * Adds this bitmap's hash to the summary of results.
+ * Adds this image to the summary of results.
*
- * @param testName name of the test
+ * @param sourceName name of the source file that generated this result
+ * @param fileName relative path to the image output file on local disk
* @param bitmap bitmap to store the hash of
+ * @param tileNumber if not NULL, ptr to tile number
*/
- void add(const char *testName, const SkBitmap& bitmap);
+ void add(const char *sourceName, const char *fileName, const SkBitmap& bitmap,
+ const int *tileNumber=NULL);
/**
* Writes the summary (as constructed so far) to a file.
@@ -67,7 +73,7 @@ public:
void writeToFile(const char *filename);
private:
- Json::Value fActualResultsNoComparison;
+ Json::Value fActualResults;
};
class PictureRenderer : public SkRefCnt {
« no previous file with comments | « no previous file | tools/PictureRenderer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698