Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: tools/PictureRenderer.h

Issue 226293002: add explicit filepaths to render_pictures JSON summary (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: unittests now pass Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/PictureRenderer.cpp » ('j') | tools/tests/render_pictures_test.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef PictureRenderer_DEFINED 8 #ifndef PictureRenderer_DEFINED
9 #define PictureRenderer_DEFINED 9 #define PictureRenderer_DEFINED
10 10
(...skipping 29 matching lines...) Expand all
40 40
41 /** 41 /**
42 * Class for collecting image results (checksums) as we go. 42 * Class for collecting image results (checksums) as we go.
43 */ 43 */
44 class ImageResultsSummary { 44 class ImageResultsSummary {
45 public: 45 public:
46 /** 46 /**
47 * Adds this bitmap hash to the summary of results. 47 * Adds this bitmap hash to the summary of results.
48 * 48 *
49 * @param testName name of the test 49 * @param testName name of the test
50 * @param fileName relative path to the image output file on local disk
50 * @param hash hash to store 51 * @param hash hash to store
51 */ 52 */
52 void add(const char *testName, uint64_t hash); 53 void add(const char *testName, const char *fileName, uint64_t hash);
53 54
54 /** 55 /**
55 * Adds this bitmap's hash to the summary of results. 56 * Adds this bitmap's hash to the summary of results.
56 * 57 *
57 * @param testName name of the test 58 * @param testName name of the test
59 * @param fileName relative path to the image output file on local disk
58 * @param bitmap bitmap to store the hash of 60 * @param bitmap bitmap to store the hash of
59 */ 61 */
60 void add(const char *testName, const SkBitmap& bitmap); 62 void add(const char *testName, const char *fileName, const SkBitmap& bitmap) ;
61 63
62 /** 64 /**
63 * Writes the summary (as constructed so far) to a file. 65 * Writes the summary (as constructed so far) to a file.
64 * 66 *
65 * @param filename path to write the summary to 67 * @param filename path to write the summary to
66 */ 68 */
67 void writeToFile(const char *filename); 69 void writeToFile(const char *filename);
68 70
69 private: 71 private:
70 Json::Value fActualResultsNoComparison; 72 Json::Value fActualResultsNoComparison;
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 667
666 typedef PictureRenderer INHERITED; 668 typedef PictureRenderer INHERITED;
667 }; 669 };
668 670
669 extern PictureRenderer* CreateGatherPixelRefsRenderer(); 671 extern PictureRenderer* CreateGatherPixelRefsRenderer();
670 extern PictureRenderer* CreatePictureCloneRenderer(); 672 extern PictureRenderer* CreatePictureCloneRenderer();
671 673
672 } 674 }
673 675
674 #endif // PictureRenderer_DEFINED 676 #endif // PictureRenderer_DEFINED
OLDNEW
« no previous file with comments | « no previous file | tools/PictureRenderer.cpp » ('j') | tools/tests/render_pictures_test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698