Issue 22629010: Reland "Make WebP decoding independent of stream length."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22629010: Reland "Make WebP decoding independent of stream length." (Closed)

Created:
7 years, 4 months ago by scroggo

Modified:
7 years, 4 months ago

Reviewers:
djsollen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Reland "Make WebP decoding independent of stream length." This reverts commit 1de924955b103c4f5dc9c46a06527d6a37e6cb70. When reading the stream, only read as much as will fit in the allocated buffer. BUG=skia:1495 Committed: https://code.google.com/p/skia/source/detail?r=10665

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Change from the original merge. #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -15 lines)			Patch
	M	src/images/SkImageDecoder_libwebp.cpp	View	1	1 chunk	+10 lines, -15 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scroggo

https://codereview.chromium.org/22629010/diff/3001/src/images/SkImageDecoder_libwebp.cpp File src/images/SkImageDecoder_libwebp.cpp (right): https://codereview.chromium.org/22629010/diff/3001/src/images/SkImageDecoder_libwebp.cpp#newcode206 src/images/SkImageDecoder_libwebp.cpp:206: bool success = true; Patch set 1 is the ...

7 years, 4 months ago (2013-08-09 19:15:32 UTC) #1

Message was sent while issue was closed.

Committed manually as r10665 (presubmit successful).

Expand Messages | Collapse Messages