Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 226283003: Remove single-window-metro-mode code paths for the app launcher and apps. (Closed)

Created:
6 years, 8 months ago by tapted
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove single-window-metro-mode code paths for the app launcher and apps. Chrome in Metro now has its own app launcher, and "SingleWindow" Metro mode is no more. This CL removes the dead code once required to tear Chrome out of metro mode in order to show the app launcher, or to launch packaged apps on the desktop. BUG=165383 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262101

Patch Set 1 #

Patch Set 2 : Removes strings #

Patch Set 3 : Thought I deleted this already #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -336 lines) Patch
M apps/app_restore_service.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M apps/apps_client.h View 1 chunk +0 lines, -5 lines 0 comments Download
M apps/launcher.cc View 4 chunks +0 lines, -14 lines 0 comments Download
M apps/shell/browser/shell_apps_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M apps/shell/browser/shell_apps_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/app/chromium_strings.grd View 1 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/apps/app_launch_for_metro_restart_win.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/apps/chrome_apps_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/apps/chrome_apps_client.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/ui/app_list/app_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_shower.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_shower.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/test/app_list_shower_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/apps/app_metro_infobar_delegate_win.h View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/ui/apps/app_metro_infobar_delegate_win.cc View 1 chunk +0 lines, -119 lines 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/linux/app_list_linux.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/activation_tracker_win.h View 3 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/activation_tracker_win.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 4 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tapted
Hi koz - please take a look. Although I just realised it's Saturday there now ...
6 years, 8 months ago (2014-04-04 18:05:36 UTC) #1
koz (OOO until 15th September)
lgtm Very nice :-)
6 years, 8 months ago (2014-04-07 05:29:00 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 8 months ago (2014-04-07 06:23:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/226283003/80001
6 years, 8 months ago (2014-04-07 06:23:12 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 09:55:28 UTC) #5
Message was sent while issue was closed.
Change committed as 262101

Powered by Google App Engine
This is Rietveld 408576698