Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Issue 2262743002: DevTools: Run devtools tests in release mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add flag Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
index 50147790121336a5c616abf62f26e1d3b062cc00..13c4180bf4c84b94138ae2f15a6361ded5267ffc 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py
@@ -459,6 +459,22 @@ class PortTest(unittest.TestCase):
self.assertEqual(port._filesystem.cwd, '/')
self.assertEqual(port.results_directory(), '/some-directory/results')
+ def test_inspector_build_directory(self):
pfeldman 2016/08/24 00:36:04 Is not worth it.
chenwilliam 2016/08/24 22:53:40 Done.
+ port = self.make_port(options=optparse.Values({'debug_devtools': True}))
+ self.assertEqual(port.inspector_build_directory(), '/mock-checkout/out/Release/resources/inspector')
+ port = self.make_port(options=optparse.Values({'debug_devtools': False}))
+ self.assertEqual(port.inspector_build_directory(), '/mock-checkout/out/Release/resources/inspector_release')
+
+ def test_additional_driver_flag(self):
+ port = self.make_port(options=optparse.Values({'debug_devtools': True}))
+ self.assertEqual(port.additional_driver_flag(), ['--run-layout-test', '--debug-devtools'])
+ port = self.make_port(options=optparse.Values({'debug_devtools': False}))
+ self.assertEqual(port.additional_driver_flag(), ['--run-layout-test'])
+
+ port = self.make_port(options=optparse.Values({'debug_devtools': True, "driver_name": "test"}))
+ self.assertEqual(port.additional_driver_flag(), ['--debug-devtools'])
+ port = self.make_port(options=optparse.Values({'debug_devtools': False, "driver_name": "test"}))
+ self.assertEqual(port.additional_driver_flag(), [])
class NaturalCompareTest(unittest.TestCase):

Powered by Google App Engine
This is Rietveld 408576698