Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/devtools/BUILD.gn

Issue 2262743002: DevTools: Run devtools tests in release mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address CL feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/profiles/profile_io_data.cc ('K') | « content/shell/common/layout_test/layout_test_switches.cc ('k') | third_party/WebKit/Source/devtools/front_end/Runtime.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/BUILD.gn
diff --git a/third_party/WebKit/Source/devtools/BUILD.gn b/third_party/WebKit/Source/devtools/BUILD.gn
index 052a9430daf04de5a3658b2b890d2b7df6c077d5..c4ec85b26653e15aad6e7f032338599127ecb55a 100644
--- a/third_party/WebKit/Source/devtools/BUILD.gn
+++ b/third_party/WebKit/Source/devtools/BUILD.gn
@@ -67,18 +67,66 @@ all_devtools_files =
resources_out_dir_no_slash = "$root_out_dir/resources/inspector"
resources_out_dir = resources_out_dir_no_slash + "/"
+resources_out_debug_dir = "$root_out_dir/resources/inspector/debug/"
+
generated_scripts = [
resources_out_dir + "InspectorBackendCommands.js",
resources_out_dir + "SupportedCSSProperties.js",
]
+generated_entry_files = [
+ resources_out_dir + "inspector.html",
+ resources_out_dir + "inspector.js",
+ resources_out_dir + "toolbox.html",
+ resources_out_dir + "toolbox.js",
+]
+
+generated_workers = [
+ resources_out_dir + "formatter_worker.js",
+ resources_out_dir + "heap_snapshot_worker.js",
+ resources_out_dir + "temp_storage_shared_worker.js",
+]
+
+generated_bundled_modules = [
+ resources_out_dir + "animation/animation_module.js",
+ resources_out_dir + "audits/audits_module.js",
+ resources_out_dir + "components_lazy/components_lazy_module.js",
+ resources_out_dir + "console/console_module.js",
+ resources_out_dir + "devices/devices_module.js",
+ resources_out_dir + "diff/diff_module.js",
+ resources_out_dir + "elements/elements_module.js",
+ resources_out_dir + "es_tree/es_tree_module.js",
+ resources_out_dir + "layers/layers_module.js",
+ resources_out_dir + "network/network_module.js",
+ resources_out_dir + "profiler/profiler_module.js",
+ resources_out_dir + "resources/resources_module.js",
+ resources_out_dir + "sass/sass_module.js",
+ resources_out_dir + "security/security_module.js",
+ resources_out_dir + "settings/settings_module.js",
+ resources_out_dir + "snippets/snippets_module.js",
+ resources_out_dir + "source_frame/source_frame_module.js",
+ resources_out_dir + "sources/sources_module.js",
+ resources_out_dir + "text_editor/text_editor_module.js",
+ resources_out_dir + "timeline_model/timeline_model_module.js",
+ resources_out_dir + "timeline/timeline_module.js",
+ resources_out_dir + "ui_lazy/ui_lazy_module.js",
+]
+
+generated_remote_modules = [
+ resources_out_dir + "accessibility/accessibility_module.js",
+ resources_out_dir + "cm_modes/cm_modes_module.js",
+ resources_out_dir + "emulated_devices/emulated_devices_module.js",
+ resources_out_dir + "gonzales/gonzales_module.js",
+ resources_out_dir + "screencast/screencast_module.js",
+]
+
#-------------------------------------------------------------------------------
visibility = [ "//third_party/WebKit/*" ]
group("devtools_frontend_resources") {
public_deps = [
- ":build_applications",
+ ":build_release_devtools",
":copy_embedder_scripts",
":copy_emulated_devices_images",
":copy_inspector_images",
@@ -86,6 +134,9 @@ group("devtools_frontend_resources") {
":frontend_protocol_sources",
":supported_css_properties",
]
+ if (debug_devtools) {
+ public_deps += [ ":build_debug_devtools" ]
+ }
}
copy("copy_embedder_scripts") {
@@ -118,57 +169,9 @@ action("generate_devtools_grd") {
inputs = gypi_values.devtools_image_files + all_devtools_files
inputs += gypi_values.devtools_embedder_scripts
- if (debug_devtools) {
- # Debug: all files are picked as-is.
- generated_files = generated_scripts + [
- resources_out_dir + "inspector.html",
- resources_out_dir + "toolbox.html",
- ]
-
- # Use a response file since the static files can be too long for the
- # command line. The args here will be added to the command line.
- static_files = all_devtools_files + [ "front_end/Runtime.js" ]
- response_file_contents = rebase_path(static_files, root_build_dir)
- static_files_args = [
- "--static_files_args",
- "{{response_file_name}}",
- ]
- } else {
- # Release: pick compiled non-remote modules and concatenated app files.
- generated_files = [
- resources_out_dir + "inspector.html",
- resources_out_dir + "inspector.js",
- resources_out_dir + "toolbox.html",
- resources_out_dir + "toolbox.js",
- resources_out_dir + "formatter_worker.js",
- resources_out_dir + "heap_snapshot_worker.js",
- resources_out_dir + "temp_storage_shared_worker.js",
- resources_out_dir + "audits/audits_module.js",
- resources_out_dir + "animation/animation_module.js",
- resources_out_dir + "components_lazy/components_lazy_module.js",
- resources_out_dir + "console/console_module.js",
- resources_out_dir + "devices/devices_module.js",
- resources_out_dir + "diff/diff_module.js",
- resources_out_dir + "elements/elements_module.js",
- resources_out_dir + "es_tree/es_tree_module.js",
- resources_out_dir + "layers/layers_module.js",
- resources_out_dir + "network/network_module.js",
- resources_out_dir + "profiler/profiler_module.js",
- resources_out_dir + "resources/resources_module.js",
- resources_out_dir + "sass/sass_module.js",
- resources_out_dir + "security/security_module.js",
- resources_out_dir + "settings/settings_module.js",
- resources_out_dir + "snippets/snippets_module.js",
- resources_out_dir + "source_frame/source_frame_module.js",
- resources_out_dir + "sources/sources_module.js",
- resources_out_dir + "text_editor/text_editor_module.js",
- resources_out_dir + "timeline_model/timeline_model_module.js",
- resources_out_dir + "timeline/timeline_module.js",
- resources_out_dir + "ui_lazy/ui_lazy_module.js",
- resources_out_dir + "devtools_extension_api.js",
- ]
- static_files_args = [] # Nothing needed for this
- }
+ generated_files =
+ generated_entry_files + generated_workers + generated_bundled_modules +
+ [ resources_out_dir + "devtools_extension_api.js" ]
images_path = "front_end/Images"
@@ -187,7 +190,7 @@ action("generate_devtools_grd") {
args = rebase_path(generated_files, root_build_dir) +
rebase_path(generated_files, root_build_dir) +
rebase_path(gypi_values.devtools_embedder_scripts, root_build_dir) +
- static_files_args + [ "--relative_path_dirs" ] +
+ [ "--relative_path_dirs" ] +
rebase_path(relative_path_dirs, root_build_dir) +
[
"--images",
@@ -242,8 +245,14 @@ action("frontend_protocol_sources") {
]
}
-action("build_applications") {
+action("build_release_devtools") {
script = "scripts/build_applications.py"
+
+ deps = [
+ ":frontend_protocol_sources",
+ ":supported_css_properties",
+ ]
+
helper_scripts = [
"scripts/modular_build.py",
"scripts/concatenate_application_code.py",
@@ -255,58 +264,10 @@ action("build_applications") {
"front_end/toolbox.html",
]
- outputs = [
- resources_out_dir + "inspector.html",
- resources_out_dir + "toolbox.html",
- ]
-
- deps = [
- ":frontend_protocol_sources",
- ":supported_css_properties",
- ]
-
- if (debug_devtools) {
- deps += [ ":copy_debug_non_modules" ]
-
- debug_mode = "1"
- } else {
- outputs += [
- resources_out_dir + "inspector.js",
- resources_out_dir + "toolbox.js",
- resources_out_dir + "formatter_worker.js",
- resources_out_dir + "heap_snapshot_worker.js",
- resources_out_dir + "temp_storage_shared_worker.js",
- resources_out_dir + "accessibility/accessibility_module.js",
- resources_out_dir + "animation/animation_module.js",
- resources_out_dir + "audits/audits_module.js",
- resources_out_dir + "cm_modes/cm_modes_module.js",
- resources_out_dir + "components_lazy/components_lazy_module.js",
- resources_out_dir + "console/console_module.js",
- resources_out_dir + "devices/devices_module.js",
- resources_out_dir + "diff/diff_module.js",
- resources_out_dir + "elements/elements_module.js",
- resources_out_dir + "emulated_devices/emulated_devices_module.js",
- resources_out_dir + "es_tree/es_tree_module.js",
- resources_out_dir + "gonzales/gonzales_module.js",
- resources_out_dir + "layers/layers_module.js",
- resources_out_dir + "network/network_module.js",
- resources_out_dir + "profiler/profiler_module.js",
- resources_out_dir + "resources/resources_module.js",
- resources_out_dir + "sass/sass_module.js",
- resources_out_dir + "screencast/screencast_module.js",
- resources_out_dir + "security/security_module.js",
- resources_out_dir + "settings/settings_module.js",
- resources_out_dir + "snippets/snippets_module.js",
- resources_out_dir + "source_frame/source_frame_module.js",
- resources_out_dir + "sources/sources_module.js",
- resources_out_dir + "text_editor/text_editor_module.js",
- resources_out_dir + "timeline_model/timeline_model_module.js",
- resources_out_dir + "timeline/timeline_module.js",
- resources_out_dir + "ui_lazy/ui_lazy_module.js",
- ]
+ outputs = generated_entry_files + generated_workers +
+ generated_bundled_modules + generated_remote_modules
- debug_mode = "0"
- }
+ debug_mode = "0"
args = [
"inspector",
@@ -324,11 +285,47 @@ action("build_applications") {
}
if (debug_devtools) {
- # Debug: copy non-module directories and core into resources_out_dir as-is.
- group("copy_debug_non_modules") {
+ action("build_debug_devtools") {
+ script = "scripts/build_applications.py"
+
+ deps = [
+ ":copy_debug_files",
+ ]
+
+ inputs = all_devtools_files + [
+ "front_end/inspector.html",
+ "front_end/toolbox.html",
+ ]
+
+ outputs = [
+ resources_out_debug_dir + "inspector.html",
+ resources_out_debug_dir + "toolbox.html",
+ ]
+
+ debug_mode = "1"
+
+ args = [
+ "inspector",
+ "toolbox",
+ "formatter_worker",
+ "heap_snapshot_worker",
+ "temp_storage_shared_worker",
+ "--input_path",
+ rebase_path("front_end", root_build_dir),
+ "--output_path",
+ rebase_path(resources_out_debug_dir, root_build_dir),
+ "--debug",
+ debug_mode,
+ ]
+ }
+
+ group("copy_debug_files") {
public_deps = [
":copy_acorn_js_files",
":copy_codemirror_files",
+ ":copy_emulated_devices_images_debug",
+ ":copy_generated_scripts",
+ ":copy_inspector_images_debug",
":copy_runtime_core",
]
}
@@ -336,14 +333,14 @@ if (debug_devtools) {
copy("copy_runtime_core") {
sources = gypi_values.devtools_core_base_files
outputs = [
- resources_out_dir + "/{{source_file_part}}",
+ resources_out_debug_dir + "/{{source_file_part}}",
]
}
copy("copy_acorn_js_files") {
sources = gypi_values.devtools_acorn_files
outputs = [
- resources_out_dir + "acorn/{{source_file_part}}",
+ resources_out_debug_dir + "acorn/{{source_file_part}}",
]
}
@@ -351,7 +348,31 @@ if (debug_devtools) {
sources =
gypi_values.devtools_cm_js_files + gypi_values.devtools_cm_css_files
outputs = [
- resources_out_dir + "cm/{{source_file_part}}",
+ resources_out_debug_dir + "cm/{{source_file_part}}",
+ ]
+ }
+
+ copy("copy_generated_scripts") {
+ deps = [
+ ":frontend_protocol_sources",
+ ":supported_css_properties",
+ ]
+ sources = generated_scripts
+ outputs = [
+ resources_out_debug_dir + "/{{source_file_part}}",
+ ]
+ }
+ copy("copy_inspector_images_debug") {
+ sources = gypi_values.devtools_image_files
+ outputs = [
+ resources_out_debug_dir + "Images/{{source_file_part}}",
+ ]
+ }
+
+ copy("copy_emulated_devices_images_debug") {
+ sources = gypi_values.devtools_emulated_devices_images
+ outputs = [
+ resources_out_debug_dir + "emulated_devices/{{source_file_part}}",
]
}
}
« chrome/browser/profiles/profile_io_data.cc ('K') | « content/shell/common/layout_test/layout_test_switches.cc ('k') | third_party/WebKit/Source/devtools/front_end/Runtime.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698