DevTools: Run devtools tests in release mode

chrome/browser/profiles/profile_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_io_data.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
@@ skipping 204 matching lines @@
   if (p.IsAbsolute())
     return false;
 
   base::FilePath inspector_dir;
   if (!PathService::Get(chrome::DIR_INSPECTOR, &inspector_dir))
     return false;
 
   if (inspector_dir.empty())
     return false;
 
-  *path = inspector_dir.AppendASCII(relative_path);
+  base::FilePath debug_path = inspector_dir.AppendASCII("debug");
+  *path = debug_path.AppendASCII(relative_path);

[mmenke, 2016/08/31 00:04:29]

Maybe *path = inspector_dir.AppendASCII("debug").AppendASCII(relative_path);?

One other FilePath variable with another name seems a little harder to follow to
me.

Also...Why is this needed?  The description does seem to say.  Maybe a comment? 
Does this need to match some other path generated elsewhere?  If so, should we
share code?

[mmenke, 2016/08/31 00:38:40]

Also, will this result in leaving junk in the old path?

[chenwilliam, 2016/08/31 00:53:06]

Done. I added a comment. This path needs to match with one in our BUILD.gn file
so I'm not sure if we can share the code. 

This shouldn't impact the old path.

   return true;
 }
 
 class DebugDevToolsInterceptor : public net::URLRequestInterceptor {
  public:
   // net::URLRequestInterceptor implementation.
   net::URLRequestJob* MaybeInterceptRequest(
       net::URLRequest* request,
       net::NetworkDelegate* network_delegate) const override {
     base::FilePath path;
@@ skipping 1140 matching lines @@
 void ProfileIOData::SetCookieSettingsForTesting(
     content_settings::CookieSettings* cookie_settings) {
   DCHECK(!cookie_settings_.get());
   cookie_settings_ = cookie_settings;
 }
 
 policy::URLBlacklist::URLBlacklistState ProfileIOData::GetURLBlacklistState(
     const GURL& url) const {
   return url_blacklist_manager_->GetURLBlacklistState(url);
 }