DevTools: Run devtools tests in release mode

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 200 matching lines @@
         self._virtual_test_suites = None
 
     def __str__(self):
         return "Port{name=%s, version=%s, architecture=%s, test_configuration=%s}" % (
             self._name, self._version, self._architecture, self._test_configuration)
 
     def buildbot_archives_baselines(self):
         return True
 
     def additional_driver_flag(self):
+        flags = []
         if self.driver_name() == self.CONTENT_SHELL_NAME:
-            return ['--run-layout-test']
-        return []
+            flags.append('--run-layout-test')
+        if self.get_option('debug_devtools'):
+            flags.append('--debug-devtools')

[pfeldman, 2016/08/24 00:36:04]

We can use additional driver flags instead.

[chenwilliam, 2016/08/24 22:53:40]

Done.

+        return flags
 
     def supports_per_test_timeout(self):
         return False
 
     def default_pixel_tests(self):
         return True
 
     def default_smoke_test_only(self):
         return False
 
@@ skipping 784 matching lines @@
             self._results_directory = self._filesystem.abspath(option_val)
         return self._results_directory
 
     def bot_test_times_path(self):
         return self._build_path('webkit_test_times', 'bot_times_ms.json')
 
     def perf_results_directory(self):
         return self._build_path()
 
     def inspector_build_directory(self):
-        return self._build_path('resources', 'inspector')
+        if self.get_option('debug_devtools'):
+            return self._build_path('resources', 'inspector')
+        return self._build_path('resources', 'inspector_release')

[pfeldman, 2016/08/24 00:36:04]

We should be able to substitute this in the native code.

[chenwilliam, 2016/08/24 22:53:40]

Done.

 
     def default_results_directory(self):
         """Absolute path to the default place to store the test results."""
         return self._build_path('layout-test-results')
 
     def setup_test_run(self):
         """Perform port-specific work at the beginning of a test run."""
         # Delete the disk cache if any to ensure a clean test run.
         dump_render_tree_binary_path = self._path_to_driver()
         cachedir = self._filesystem.dirname(dump_render_tree_binary_path)
@@ skipping 748 matching lines @@
 
     def __init__(self, base, args, reference_args=None):
         self.name = base
         self.base = base
         self.args = args
         self.reference_args = args if reference_args is None else reference_args
         self.tests = set()
 
     def __repr__(self):
         return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)