Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2262733002: Land a testing Finch config for the Chrome Sign in promo in the password bubble. (Closed)

Created:
4 years, 4 months ago by vasilii
Modified:
4 years, 4 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land a testing Finch config for the Chrome Sign in promo in the password bubble. BUG=615825 Committed: https://crrev.com/4dc36bb1e792683d896d50f8e6a0405622e4fc5c Cr-Commit-Position: refs/heads/master@{#413426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
vasilii
Hi Ilya, please review. The launch was approved on Stable.
4 years, 4 months ago (2016-08-19 16:56:41 UTC) #4
Ilya Sherman
LGTM. Did you want to include ChromeOS as well?
4 years, 4 months ago (2016-08-19 23:22:41 UTC) #7
vasilii
On 2016/08/19 23:22:41, Ilya Sherman wrote: > LGTM. Did you want to include ChromeOS as ...
4 years, 4 months ago (2016-08-22 08:47:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262733002/1
4 years, 4 months ago (2016-08-22 08:48:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 09:43:46 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 09:45:08 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4dc36bb1e792683d896d50f8e6a0405622e4fc5c
Cr-Commit-Position: refs/heads/master@{#413426}

Powered by Google App Engine
This is Rietveld 408576698