Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6263)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/metrics/proto/chrome_user_metrics_extension.proto

Issue 226273004: Add new SampledProfile protobuf definition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated repeated field name, seconds -> milliseconds, INTERVAL -> PERIODIC Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/metrics/proto/profile_collection.proto » ('j') | chrome/common/metrics/proto/profile_collection.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/metrics/proto/chrome_user_metrics_extension.proto
diff --git a/chrome/common/metrics/proto/chrome_user_metrics_extension.proto b/chrome/common/metrics/proto/chrome_user_metrics_extension.proto
index a5a6de0bfff8eda020ffca185bf307ad345028c4..9d88f4c6fc6f5a9b0cfaa0d1d46201ea2b64e3ed 100644
--- a/chrome/common/metrics/proto/chrome_user_metrics_extension.proto
+++ b/chrome/common/metrics/proto/chrome_user_metrics_extension.proto
@@ -16,6 +16,7 @@ import "profiler_event.proto";
import "system_profile.proto";
import "user_action_event.proto";
import "perf_data.proto";
+import "profile_collection.proto";
// Next tag: 11
message ChromeUserMetricsExtension {
@@ -54,5 +55,9 @@ message ChromeUserMetricsExtension {
repeated HistogramEventProto histogram_event = 6;
repeated ProfilerEventProto profiler_event = 7;
+ // TODO(sque): Remove this field and use |collected_profiles| instead.
tipp 2014/04/08 21:19:41 stale comment s/collected_profiles/profile/
Simon Que 2014/04/08 22:57:44 Done.
repeated PerfDataProto perf_data = 8;
+
+ // A list of all collected profiles since the last UMA upload.
+ repeated ProfileCollection profiles = 9;
tipp 2014/04/08 21:19:41 s/profiles/profile/
Simon Que 2014/04/08 22:57:44 Done.
}
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/metrics/proto/profile_collection.proto » ('j') | chrome/common/metrics/proto/profile_collection.proto » ('J')

Powered by Google App Engine
This is Rietveld 408576698