Add new SampledProfile protobuf definition

Add new SampledProfile protobuf definition

This will replace the repeated PerfDataProto field in the UMA protobuf. It
provides for more metadata surrounding the collection of each profile. It
also allows for more types of profiles to be collected, other than perf.

BUG=chromium:358778
TEST=build successfully

Signed-off-by: Simon Que <sque@chromium.org>;

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270832

[Simon Que, 2014-04-04 19:51:15]

Somehow there's a bunch of changes introduced by user "gitdeps" in .gitmodules.
The following is a grep of all those lines in the git blame view of .gitmodules:

(sdk lumpy R35-5661.0.0) sque@sq: ~/cros/chromium/src $ git blame .gitmodules |
grep gitdeps
1fde9ba8 (gitdeps               2014-02-01 21:54:23 -0800 109) [submodule
"third_party/clang_format/script"]
1fde9ba8 (gitdeps               2014-02-01 21:54:23 -0800 110) 	path =
third_party/clang_format/script
1fde9ba8 (gitdeps               2014-02-01 21:54:23 -0800 111) 	url =
https://chromium.googlesource.com/chromium/llvm-project/cfe/tools/clang-forma...
1fde9ba8 (gitdeps               2014-02-01 21:54:23 -0800 112) 	os = all
c45ff9ac (gitdeps               2014-03-04 22:28:22 -0800 219) 	url =
https://chromium.googlesource.com/chromium/llvm-project/libcxx.git
c45ff9ac (gitdeps               2014-03-04 22:28:22 -0800 223) 	url =
https://chromium.googlesource.com/chromium/llvm-project/libcxxabi.git
dda05c83 (gitdeps               2014-03-12 02:35:24 -0700 300) 	os = all
eb47b596 (gitdeps               2014-03-06 14:47:26 -0800 404) 	os = unix

[tipp, 2014-04-04 23:01:37]

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
File chrome/common/metrics/proto/chrome_user_metrics_extension.proto (right):

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
chrome/common/metrics/proto/chrome_user_metrics_extension.proto:62: repeated
ProfileCollection collected_profiles = 9;
s/collected_profiles/profile/
(not plural, oddly: see http://go/protostyle )

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
File chrome/common/metrics/proto/profile_collection.proto (right):

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
chrome/common/metrics/proto/profile_collection.proto:21: INTERVAL = 1;     //
Collect at a random point within regular intervals.
s/INTERVAL/PERIODIC/

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
chrome/common/metrics/proto/profile_collection.proto:35: optional int64
seconds_after_boot = 4;
seconds are a long time.  make all of these millis.

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
chrome/common/metrics/proto/profile_collection.proto:41: optional int64
interval_length_seconds = 6;
s/length/period/

[Simon Que, 2014-04-04 23:57:08]

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
File chrome/common/metrics/proto/chrome_user_metrics_extension.proto (right):

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
chrome/common/metrics/proto/chrome_user_metrics_extension.proto:62: repeated
ProfileCollection collected_profiles = 9;
On 2014/04/04 23:01:37, tipp wrote:
> s/collected_profiles/profile/
> (not plural, oddly: see http://go/protostyle )

Done.

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
File chrome/common/metrics/proto/profile_collection.proto (right):

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
chrome/common/metrics/proto/profile_collection.proto:21: INTERVAL = 1;     //
Collect at a random point within regular intervals.
On 2014/04/04 23:01:37, tipp wrote:
> s/INTERVAL/PERIODIC/

Done.

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
chrome/common/metrics/proto/profile_collection.proto:35: optional int64
seconds_after_boot = 4;
On 2014/04/04 23:01:37, tipp wrote:
> seconds are a long time.  make all of these millis.

Done.

https://codereview.chromium.org/226273004/diff/30001/chrome/common/metrics/pr...
chrome/common/metrics/proto/profile_collection.proto:41: optional int64
interval_length_seconds = 6;
On 2014/04/04 23:01:37, tipp wrote:
> s/length/period/

Done.

[battre, 2014-04-07 07:56:21]

Privacy wise LGTM

[Ilya Sherman, 2014-04-07 22:16:36]

Please upload these changes for review in the google3 repository first.  I can
do a first-pass review, and then the logs team will want to take a look as well.
 Once those land, I'll happily stamp a CL to clone those changes into the
Chromium repo.

[tipp, 2014-04-08 21:19:40]

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
File chrome/common/metrics/proto/chrome_user_metrics_extension.proto (right):

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
chrome/common/metrics/proto/chrome_user_metrics_extension.proto:58: //
TODO(sque): Remove this field and use |collected_profiles| instead.
stale comment s/collected_profiles/profile/

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
chrome/common/metrics/proto/chrome_user_metrics_extension.proto:62: repeated
ProfileCollection profiles = 9;
s/profiles/profile/

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
File chrome/common/metrics/proto/profile_collection.proto (right):

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
chrome/common/metrics/proto/profile_collection.proto:27: PERF = 0;         //
Perf profile.
Make UNKNOWN=0 and PERF=1

[Simon Que, 2014-04-08 22:57:44]

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
File chrome/common/metrics/proto/chrome_user_metrics_extension.proto (right):

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
chrome/common/metrics/proto/chrome_user_metrics_extension.proto:58: //
TODO(sque): Remove this field and use |collected_profiles| instead.
On 2014/04/08 21:19:41, tipp wrote:
> stale comment s/collected_profiles/profile/

Done.

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
chrome/common/metrics/proto/chrome_user_metrics_extension.proto:62: repeated
ProfileCollection profiles = 9;
On 2014/04/08 21:19:41, tipp wrote:
> s/profiles/profile/

Done.

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
File chrome/common/metrics/proto/profile_collection.proto (right):

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
chrome/common/metrics/proto/profile_collection.proto:27: PERF = 0;         //
Perf profile.
On 2014/04/08 21:19:41, tipp wrote:
> Make UNKNOWN=0 and PERF=1

When would we use the unknown enum? We can always determine it from which
profile field is set.

[tipp, 2014-04-08 23:31:46]

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
File chrome/common/metrics/proto/profile_collection.proto (right):

https://codereview.chromium.org/226273004/diff/50001/chrome/common/metrics/pr...
chrome/common/metrics/proto/profile_collection.proto:27: PERF = 0;         //
Perf profile.
On 2014/04/08 22:57:44, Simon Que wrote:
> On 2014/04/08 21:19:41, tipp wrote:
> > Make UNKNOWN=0 and PERF=1
> 
> When would we use the unknown enum? We can always determine it from which
> profile field is set.

#5 from http://go/protodosdonts

[Simon Que, 2014-05-15 18:54:23]

PTAL

[Ilya Sherman, 2014-05-15 18:56:48]

LGTM with nits addressed.  Thanks.

https://codereview.chromium.org/226273004/diff/110001/components/metrics/prot...
File components/metrics/proto/sampled_profile.proto (right):

https://codereview.chromium.org/226273004/diff/110001/components/metrics/prot...
components/metrics/proto/sampled_profile.proto:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
ultra nit: No need for "(c)".

https://codereview.chromium.org/226273004/diff/110001/components/metrics/prot...
components/metrics/proto/sampled_profile.proto:5: // A profile that was
collected by sampling.
nit: This is redundant with lines 15-16.  I'd recommend just omitting this line.

[Simon Que, 2014-05-15 18:59:57]

https://codereview.chromium.org/226273004/diff/110001/components/metrics/prot...
File components/metrics/proto/sampled_profile.proto (right):

https://codereview.chromium.org/226273004/diff/110001/components/metrics/prot...
components/metrics/proto/sampled_profile.proto:1: // Copyright (c) 2014 The
Chromium Authors. All rights reserved.
On 2014/05/15 18:56:48, Ilya Sherman wrote:
> ultra nit: No need for "(c)".

Done.

https://codereview.chromium.org/226273004/diff/110001/components/metrics/prot...
components/metrics/proto/sampled_profile.proto:5: // A profile that was
collected by sampling.
On 2014/05/15 18:56:48, Ilya Sherman wrote:
> nit: This is redundant with lines 15-16.  I'd recommend just omitting this
line.

Done.

[Simon Que, 2014-05-15 19:00:32]

The CQ bit was checked by sque@chromium.org

[commit-bot: I haz the power, 2014-05-15 19:01:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sque@chromium.org/226273004/130001

[commit-bot: I haz the power, 2014-05-15 22:22:06]

Change committed as 270832