Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2262723002: arc: Fix crash on Arc window close. (Closed)

Created:
4 years, 4 months ago by khmel
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

arc: Fix crash on Arc window close. BUG=638261 BUG=b/30817552 TEST=Manually on device. No more crashes are observed. NOTRY=true NOPRESUBMIT=true TBR=oshima@chromium.org Review-Url: https://codereview.chromium.org/2251493002 Cr-Commit-Position: refs/heads/master@{#412390} (cherry picked from commit 323b4a4792b0c6eb7e51d2aee66773378229e486)

Patch Set 1 #

Patch Set 2 : patch for M53 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -37 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 1 5 chunks +68 lines, -36 lines 1 comment Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
khmel
https://codereview.chromium.org/2262723002/diff/20001/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc File chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc (right): https://codereview.chromium.org/2262723002/diff/20001/chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc#newcode274 chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc:274: // Special for M53 branch. Due different deletion order ...
4 years, 4 months ago (2016-08-19 21:00:12 UTC) #1
khmel
4 years, 4 months ago (2016-08-19 21:00:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262723002/20001
4 years, 4 months ago (2016-08-19 21:03:30 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 21:04:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698