Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3992)

Unified Diff: chrome/common/pepper_flash.cc

Issue 2262713003: Consistently use namespaced base::Version in plugins code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/plugins/plugin_metadata_unittest.cc ('k') | content/browser/plugin_data_remover_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/pepper_flash.cc
diff --git a/chrome/common/pepper_flash.cc b/chrome/common/pepper_flash.cc
index cad919947ea4b0f1de6a064de174363a56b38ac5..7eb5ae15085c33c9d1cb8af990e82354fc20076e 100644
--- a/chrome/common/pepper_flash.cc
+++ b/chrome/common/pepper_flash.cc
@@ -95,7 +95,7 @@ bool CheckPepperFlashInterfaces(const base::DictionaryValue& manifest) {
} // namespace
bool CheckPepperFlashManifest(const base::DictionaryValue& manifest,
- Version* version_out) {
+ base::Version* version_out) {
std::string name;
manifest.GetStringASCII("name", &name);
// TODO(viettrungluu): Support WinFlapper for now, while we change the format
@@ -106,7 +106,7 @@ bool CheckPepperFlashManifest(const base::DictionaryValue& manifest,
std::string proposed_version;
manifest.GetStringASCII("version", &proposed_version);
- Version version(proposed_version.c_str());
+ base::Version version(proposed_version.c_str());
if (!version.IsValid())
return false;
« no previous file with comments | « chrome/browser/plugins/plugin_metadata_unittest.cc ('k') | content/browser/plugin_data_remover_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698