Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2262693002: Initialize OSCrypt with a TaskRunner on the main thread (Closed)

Created:
4 years, 4 months ago by cfroussios
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize OSCrypt with a TaskRunner on the main thread Gnome-Keyring requires calls to originate from the main thread. In order to support Gnome-Keyring on OSCrypt, we initialize it with a SingleThreadTaskRunner. In addition, the various static fields for OSCrypt's initialization have been grouped into a struct. BUG=602624 Committed: https://crrev.com/c51d7ae19a5e001eb9aea418b3efc83fcc9b4649 Cr-Commit-Position: refs/heads/master@{#413110}

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -7 lines) Patch
M chrome/browser/chrome_browser_main_linux.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/os_crypt/key_storage_linux.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M components/os_crypt/key_storage_linux.cc View 1 3 chunks +24 lines, -7 lines 0 comments Download
M components/os_crypt/os_crypt.h View 2 chunks +8 lines, -0 lines 0 comments Download
M components/os_crypt/os_crypt_linux.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
cfroussios
Hi! Can you review this change? Thanks!
4 years, 4 months ago (2016-08-19 10:55:30 UTC) #8
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-19 11:56:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262693002/20001
4 years, 4 months ago (2016-08-19 11:57:26 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-19 12:01:37 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 12:04:47 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c51d7ae19a5e001eb9aea418b3efc83fcc9b4649
Cr-Commit-Position: refs/heads/master@{#413110}

Powered by Google App Engine
This is Rietveld 408576698