Make URLRequest::Read to return net errors or bytes read instead of a bool

net/base/layered_network_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_LAYERED_NETWORK_DELEGATE_H_
 #define NET_BASE_LAYERED_NETWORK_DELEGATE_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 41 matching lines @@
                            HttpRequestHeaders* headers) final;
   void OnStartTransaction(URLRequest* request,
                           const HttpRequestHeaders& headers) final;
   int OnHeadersReceived(
       URLRequest* request,
       const CompletionCallback& callback,
       const HttpResponseHeaders* original_response_headers,
       scoped_refptr<HttpResponseHeaders>* override_response_headers,
       GURL* allowed_unsafe_redirect_url) final;
   void OnBeforeRedirect(URLRequest* request, const GURL& new_location) final;
-  void OnResponseStarted(URLRequest* request) final;
+
+  void OnResponseStarted(URLRequest* request, int net_error) final;

[battre, 2016/09/29 13:07:29]

Shouldn't this be "net::Error net_error" (also in all other cases)?

   void OnNetworkBytesReceived(URLRequest* request,
                               int64_t bytes_received) final;
   void OnNetworkBytesSent(URLRequest* request, int64_t bytes_sent) final;
-  void OnCompleted(URLRequest* request, bool started) final;
+  void OnCompleted(URLRequest* request, bool started, int net_error) final;
   void OnURLRequestDestroyed(URLRequest* request) final;
   void OnPACScriptError(int line_number, const base::string16& error) final;
   AuthRequiredResponse OnAuthRequired(URLRequest* request,
                                       const AuthChallengeInfo& auth_info,
                                       const AuthCallback& callback,
                                       AuthCredentials* credentials) final;
   bool OnCanGetCookies(const URLRequest& request,
                        const CookieList& cookie_list) final;
   bool OnCanSetCookie(const URLRequest& request,
                       const std::string& cookie_line,
@@ skipping 80 matching lines @@
       const GURL& target_url,
       const GURL& referrer_url) const;
 
  private:
   std::unique_ptr<NetworkDelegate> nested_network_delegate_;
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_LAYERED_NETWORK_DELEGATE_H_