Make URLRequest::Read to return net errors or bytes read instead of a bool

content/browser/webui/url_data_manager_backend_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/webui/url_data_manager_backend.h"
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "content/public/test/mock_resource_context.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "net/http/http_response_headers.h"
 #include "net/http/http_response_info.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_job.h"
 #include "net/url_request/url_request_job_factory_impl.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace content {
 
 class CancelAfterFirstReadURLRequestDelegate : public net::TestDelegate {
  public:
   CancelAfterFirstReadURLRequestDelegate() {}
 
   ~CancelAfterFirstReadURLRequestDelegate() override {}
 
-  void OnResponseStarted(net::URLRequest* request) override {
+  void OnResponseStarted(net::URLRequest* request, int net_error) override {
     // net::TestDelegate will start the first read.
-    TestDelegate::OnResponseStarted(request);
+    TestDelegate::OnResponseStarted(request, net_error);
     request->Cancel();
   }
 
   void OnReadCompleted(net::URLRequest* request, int bytes_read) override {
     // Read should have been cancelled.
-    EXPECT_EQ(-1, bytes_read);
+    EXPECT_EQ(net::ERR_ABORTED, bytes_read);
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CancelAfterFirstReadURLRequestDelegate);
 };
 
 class UrlDataManagerBackendTest : public testing::Test {
  public:
   UrlDataManagerBackendTest()
       : thread_bundle_(TestBrowserThreadBundle::IO_MAINLOOP) {
@@ skipping 82 matching lines @@
   std::unique_ptr<net::URLRequest> error_request =
       url_request_context_.CreateRequest(
           GURL("chrome://network-error/-123456789"), net::HIGHEST, &delegate_);
   error_request->Start();
   base::RunLoop().Run();
   EXPECT_EQ(net::URLRequestStatus::FAILED, error_request->status().status());
   EXPECT_EQ(net::ERR_INVALID_URL, error_request->status().error());
 }
 
 }  // namespace content