Make URLRequest::Read to return net errors or bytes read instead of a bool

net/base/network_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NETWORK_DELEGATE_H_
 #define NET_BASE_NETWORK_DELEGATE_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 62 matching lines @@
   void NotifyStartTransaction(URLRequest* request,
                               const HttpRequestHeaders& headers);
   int NotifyHeadersReceived(
       URLRequest* request,
       const CompletionCallback& callback,
       const HttpResponseHeaders* original_response_headers,
       scoped_refptr<HttpResponseHeaders>* override_response_headers,
       GURL* allowed_unsafe_redirect_url);
   void NotifyBeforeRedirect(URLRequest* request,
                             const GURL& new_location);
+  void NotifyResponseStarted(URLRequest* request, int net_error);
+  // Deprecated.
   void NotifyResponseStarted(URLRequest* request);
   void NotifyNetworkBytesReceived(URLRequest* request, int64_t bytes_received);
   void NotifyNetworkBytesSent(URLRequest* request, int64_t bytes_sent);
+  void NotifyCompleted(URLRequest* request, bool started, int net_error);
+  // Deprecated.
   void NotifyCompleted(URLRequest* request, bool started);
   void NotifyURLRequestDestroyed(URLRequest* request);
   void NotifyPACScriptError(int line_number, const base::string16& error);
   AuthRequiredResponse NotifyAuthRequired(URLRequest* request,
                                           const AuthChallengeInfo& auth_info,
                                           const AuthCallback& callback,
                                           AuthCredentials* credentials);
   bool CanGetCookies(const URLRequest& request,
                      const CookieList& cookie_list);
   bool CanSetCookie(const URLRequest& request,
                     const std::string& cookie_line,
                     CookieOptions* options);
   bool CanAccessFile(const URLRequest& request,
                      const base::FilePath& path) const;
   bool CanEnablePrivacyMode(const GURL& url,
                             const GURL& first_party_for_cookies) const;
 
   bool AreExperimentalCookieFeaturesEnabled() const;
 
   // TODO(jww): Remove this once we ship strict secure cookies:
   // https://crbug.com/546820
   bool AreStrictSecureCookiesEnabled() const;
 
   bool CancelURLRequestWithPolicyViolatingReferrerHeader(
       const URLRequest& request,
       const GURL& target_url,
       const GURL& referrer_url) const;
 
+ protected:
+  // Let NetworkDelegateImpl to set |not_implemented_| value.
+  // See the comment bellow that explains what this value means.
+  void set_implemented(bool value) { implemented_ = value; }
+
  private:
   // This is the interface for subclasses of NetworkDelegate to implement. These
   // member functions will be called by the respective public notification
   // member function, which will perform basic sanity checking.
 
   // Called before a request is sent. Allows the delegate to rewrite the URL
   // being fetched by modifying |new_url|. If set, the URL must be valid. The
   // reference fragment from the original URL is not automatically appended to
   // |new_url|; callers are responsible for copying the reference fragment if
   // desired.
@@ skipping 54 matching lines @@
       scoped_refptr<HttpResponseHeaders>* override_response_headers,
       GURL* allowed_unsafe_redirect_url) = 0;
 
   // Called right after a redirect response code was received.
   // |new_location| is only valid until OnURLRequestDestroyed is called for this
   // request.
   virtual void OnBeforeRedirect(URLRequest* request,
                                 const GURL& new_location) = 0;
 
   // This corresponds to URLRequestDelegate::OnResponseStarted.
-  virtual void OnResponseStarted(URLRequest* request) = 0;
+  virtual void OnResponseStarted(URLRequest* request, int net_error);
+  // Deprecated.
+  virtual void OnResponseStarted(URLRequest* request);
 
   // Called when bytes are received from the network, such as after receiving
   // headers or reading raw response bytes. This includes localhost requests.
   // |bytes_received| is the number of bytes measured at the application layer
   // that have been received over the network for this request since the last
   // time OnNetworkBytesReceived was called. |bytes_received| will always be
   // greater than 0.
   // Currently, this is only implemented for HTTP transactions, and
   // |bytes_received| does not include TLS overhead or TCP retransmits.
   virtual void OnNetworkBytesReceived(URLRequest* request,
                                       int64_t bytes_received) = 0;
 
   // Called when bytes are sent over the network, such as when sending request
   // headers or uploading request body bytes. This includes localhost requests.
   // |bytes_sent| is the number of bytes measured at the application layer that
   // have been sent over the network for this request since the last time
   // OnNetworkBytesSent was called. |bytes_sent| will always be greater than 0.
   // Currently, this is only implemented for HTTP transactions, and |bytes_sent|
   // does not include TLS overhead or TCP retransmits.
   virtual void OnNetworkBytesSent(URLRequest* request, int64_t bytes_sent) = 0;
 
   // Indicates that the URL request has been completed or failed.
   // |started| indicates whether the request has been started. If false,
   // some information like the socket address is not available.
-  virtual void OnCompleted(URLRequest* request, bool started) = 0;
+  virtual void OnCompleted(URLRequest* request, bool started, int net_error);
+  // Deprecated.
+  virtual void OnCompleted(URLRequest* request, bool started);
 
   // Called when an URLRequest is being destroyed. Note that the request is
   // being deleted, so it's not safe to call any methods that may result in
   // a virtual method call.
   virtual void OnURLRequestDestroyed(URLRequest* request) = 0;
 
   // Corresponds to ProxyResolverJSBindings::OnError.
   virtual void OnPACScriptError(int line_number,
                                 const base::string16& error) = 0;
 
@@ skipping 59 matching lines @@
 
   // Called when the |referrer_url| for requesting |target_url| during handling
   // of the |request| is does not comply with the referrer policy (e.g. a
   // secure referrer for an insecure initial target).
   // Returns true if the request should be cancelled. Otherwise, the referrer
   // header is stripped from the request.
   virtual bool OnCancelURLRequestWithPolicyViolatingReferrerHeader(
       const URLRequest& request,
       const GURL& target_url,
       const GURL& referrer_url) const = 0;
+
+  // Used to distinguish whether modified a method is overridden by clients.
+  bool implemented_;

[mmenke, 2016/08/30 22:09:11]

No longer used

[maksims (do not use this acc), 2016/08/31 11:16:59]

Hmm, interesting. I've seen build-bots has been failing recently when a variable
is not used, but not this time. It's strange they didn't complain about that. 

[mmenke, 2016/08/31 21:35:47]

The checks don't detect class members that aren't used, just globals and locals.

 };
 
 }  // namespace net
 
 #endif  // NET_BASE_NETWORK_DELEGATE_H_