Make URLRequest::Read to return net errors or bytes read instead of a bool

net/base/network_delegate_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/network_delegate_impl.h"
 
 #include "net/base/net_errors.h"
 
 namespace net {
 
@@ skipping 23 matching lines @@
 int NetworkDelegateImpl::OnHeadersReceived(
     URLRequest* request,
     const CompletionCallback& callback,
     const HttpResponseHeaders* original_response_headers,
     scoped_refptr<HttpResponseHeaders>* override_response_headers,
     GURL* allowed_unsafe_redirect_url) {
   return OK;
 }
 
 void NetworkDelegateImpl::OnBeforeRedirect(URLRequest* request,
-                                           const GURL& new_location) {
+                                           const GURL& new_location) {}
+
+void NetworkDelegateImpl::OnResponseStarted(URLRequest* request,
+                                            int net_error) {
+  set_implemented(false);
 }
 
-void NetworkDelegateImpl::OnResponseStarted(URLRequest* request) {
-}
+// Deprecated.
+void NetworkDelegateImpl::OnResponseStarted(URLRequest* request) {}
 
 void NetworkDelegateImpl::OnNetworkBytesReceived(URLRequest* request,
                                                  int64_t bytes_received) {}
 
 void NetworkDelegateImpl::OnNetworkBytesSent(URLRequest* request,
                                              int64_t bytes_sent) {}
 
-void NetworkDelegateImpl::OnCompleted(URLRequest* request, bool started) {
+void NetworkDelegateImpl::OnCompleted(URLRequest* request,
+                                      bool started,
+                                      int net_error) {
+  set_implemented(false);
 }
 
+// Deprecated.
+void NetworkDelegateImpl::OnCompleted(URLRequest* request, bool started) {}
+
 void NetworkDelegateImpl::OnURLRequestDestroyed(URLRequest* request) {
 }
 
 void NetworkDelegateImpl::OnPACScriptError(int line_number,
                                            const base::string16& error) {
 }
 
 NetworkDelegate::AuthRequiredResponse NetworkDelegateImpl::OnAuthRequired(
     URLRequest* request,
     const AuthChallengeInfo& auth_info,
@@ skipping 33 matching lines @@
 }
 
 bool NetworkDelegateImpl::OnCancelURLRequestWithPolicyViolatingReferrerHeader(
     const URLRequest& request,
     const GURL& target_url,
     const GURL& referrer_url) const {
   return false;
 }
 
 }  // namespace net