Make URLRequest::Read to return net errors or bytes read instead of a bool

net/base/layered_network_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/layered_network_delegate.h"
 
 #include <utility>
 
 namespace net {
 
@@ skipping 86 matching lines @@
                                               const GURL& new_location) {
   OnBeforeRedirectInternal(request, new_location);
   nested_network_delegate_->NotifyBeforeRedirect(request, new_location);
 }
 
 void LayeredNetworkDelegate::OnBeforeRedirectInternal(
     URLRequest* request,
     const GURL& new_location) {
 }
 
+void LayeredNetworkDelegate::OnResponseStarted(URLRequest* request,
+                                               int net_error) {
+  OnResponseStartedInternal(request);
+  nested_network_delegate_->NotifyResponseStarted(request, net_error);
+}
+
+// Deprecated
 void LayeredNetworkDelegate::OnResponseStarted(URLRequest* request) {
   OnResponseStartedInternal(request);
   nested_network_delegate_->NotifyResponseStarted(request);
 }
 
 void LayeredNetworkDelegate::OnResponseStartedInternal(URLRequest* request) {
 }
 
 void LayeredNetworkDelegate::OnNetworkBytesReceived(URLRequest* request,
                                                     int64_t bytes_received) {
   OnNetworkBytesReceivedInternal(request, bytes_received);
   nested_network_delegate_->NotifyNetworkBytesReceived(request, bytes_received);
 }
 
 void LayeredNetworkDelegate::OnNetworkBytesReceivedInternal(
     URLRequest* request,
     int64_t bytes_received) {}
 
 void LayeredNetworkDelegate::OnNetworkBytesSent(URLRequest* request,
                                                 int64_t bytes_sent) {
   OnNetworkBytesSentInternal(request, bytes_sent);
   nested_network_delegate_->NotifyNetworkBytesSent(request, bytes_sent);
 }
 
 void LayeredNetworkDelegate::OnNetworkBytesSentInternal(URLRequest* request,
                                                         int64_t bytes_sent) {}
 
+void LayeredNetworkDelegate::OnCompleted(URLRequest* request,
+                                         bool started,
+                                         int net_error) {
+  OnCompletedInternal(request, started);
+  nested_network_delegate_->NotifyCompleted(request, started, net_error);
+}
+
+// Deprecated.
 void LayeredNetworkDelegate::OnCompleted(URLRequest* request, bool started) {
   OnCompletedInternal(request, started);
   nested_network_delegate_->NotifyCompleted(request, started);
 }
 
 void LayeredNetworkDelegate::OnCompletedInternal(URLRequest* request,
-                                                 bool started) {
-}
+                                                 bool started) {}
 
 void LayeredNetworkDelegate::OnURLRequestDestroyed(URLRequest* request) {
   OnURLRequestDestroyedInternal(request);
   nested_network_delegate_->NotifyURLRequestDestroyed(request);
 }
 
 void LayeredNetworkDelegate::OnURLRequestDestroyedInternal(
     URLRequest* request) {
 }
 
@@ skipping 101 matching lines @@
 }
 
 void LayeredNetworkDelegate::
     OnCancelURLRequestWithPolicyViolatingReferrerHeaderInternal(
         const URLRequest& request,
         const GURL& target_url,
         const GURL& referrer_url) const {
 }
 
 }  // namespace net