Issue 226263005: Mojo: Abstract out write/writev vs send/sendmsg (for Unix domain sockets).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226263005: Mojo: Abstract out write/writev vs send/sendmsg (for Unix domain sockets). (Closed)

Created:
6 years, 8 months ago by viettrungluu

Modified:
6 years, 8 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Mojo: Abstract out write/writev vs send/sendmsg (for Unix domain sockets). I thought I had fixed our SIGPIPE suppression, but I was wrong (missed the write() case). So I guess I should do the right thing. R=darin@chromium.org BUG=356195 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261996

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -29 lines)			Patch
M	mojo/embedder/platform_channel_pair.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	mojo/embedder/platform_channel_pair_posix_unittest.cc	View	2 chunks	+14 lines, -10 lines	0 comments	Download
A	mojo/embedder/platform_channel_utils_posix.h	View	1 chunk	+33 lines, -0 lines	0 comments	Download
A	mojo/embedder/platform_channel_utils_posix.cc	View	1 chunk	+63 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/system/raw_channel_posix.cc	View	4 chunks	+5 lines, -19 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/226263005/1

6 years, 8 months ago (2014-04-05 06:50:23 UTC) #5

Message was sent while issue was closed.

Change committed as 261996