Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2262623002:
Build rule for pdf_hint_table_fuzzer (Closed)
DescriptionBuild rule for pdf_hint_table_fuzzer
Add the Chromium side build rules for the hint table fuzzer.
BUG=636559
Committed: https://crrev.com/e8ad85572cd463bfb07d89140267e47e507f1caa
Cr-Commit-Position: refs/heads/master@{#413320}
Patch Set 1 #
Total comments: 2
Patch Set 2 : rebase, no non-existent corpora #Messages
Total messages: 16 (6 generated)
thestig@chromium.org changed reviewers: + mmoroz@chromium.org, ochang@chromium.org
Follow up once https://codereview.chromium.org/2255083004/ lands and DEPS gets rolled.
https://codereview.chromium.org/2262623002/diff/1/pdf/pdfium/fuzzers/BUILD.gn File pdf/pdfium/fuzzers/BUILD.gn (right): https://codereview.chromium.org/2262623002/diff/1/pdf/pdfium/fuzzers/BUILD.gn... pdf/pdfium/fuzzers/BUILD.gn:44: seed_corpus = "corpora/pdf_hint_table" pdf/pdfium/fuzzers/corpora/pdf_hint_table doesn't seem to exist, and isn't added by this CL?
https://codereview.chromium.org/2262623002/diff/1/pdf/pdfium/fuzzers/BUILD.gn File pdf/pdfium/fuzzers/BUILD.gn (right): https://codereview.chromium.org/2262623002/diff/1/pdf/pdfium/fuzzers/BUILD.gn... pdf/pdfium/fuzzers/BUILD.gn:44: seed_corpus = "corpora/pdf_hint_table" On 2016/08/19 19:02:26, Oliver Chang wrote: > pdf/pdfium/fuzzers/corpora/pdf_hint_table doesn't seem to exist, and isn't added > by this CL? I don't actually have a seed_corpus. This is just copy + pasted from above. Delete?
On 2016/08/19 19:03:23, Lei Zhang wrote: > https://codereview.chromium.org/2262623002/diff/1/pdf/pdfium/fuzzers/BUILD.gn > File pdf/pdfium/fuzzers/BUILD.gn (right): > > https://codereview.chromium.org/2262623002/diff/1/pdf/pdfium/fuzzers/BUILD.gn... > pdf/pdfium/fuzzers/BUILD.gn:44: seed_corpus = "corpora/pdf_hint_table" > On 2016/08/19 19:02:26, Oliver Chang wrote: > > pdf/pdfium/fuzzers/corpora/pdf_hint_table doesn't seem to exist, and isn't > added > > by this CL? > > I don't actually have a seed_corpus. This is just copy + pasted from above. > Delete? yeah, doesn't make sense to have it if it doesn't exist (it might also break things). lgtm otherwise
On 2016/08/19 19:10:03, Oliver Chang wrote: > yeah, doesn't make sense to have it if it doesn't exist (it might also break > things). Done, and put it in alphabetical order. (It was originally named pdf_page_hint_table_fuzzer) Waiting for the PDFium auto-roller to do its job before this can land.
The CQ bit was checked by thestig@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org Link to the patchset: https://codereview.chromium.org/2262623002/#ps20001 (title: "rebase, no non-existent corpora")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Build rule for pdf_hint_table_fuzzer Add the Chromium side build rules for the hint table fuzzer. BUG=636559 ========== to ========== Build rule for pdf_hint_table_fuzzer Add the Chromium side build rules for the hint table fuzzer. BUG=636559 Committed: https://crrev.com/e8ad85572cd463bfb07d89140267e47e507f1caa Cr-Commit-Position: refs/heads/master@{#413320} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e8ad85572cd463bfb07d89140267e47e507f1caa Cr-Commit-Position: refs/heads/master@{#413320} |
