Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Unified Diff: chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc

Issue 2262583002: Do not request upgrade if Web Manifest is no longer WebAPK-capable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_updater_non_installable Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc
diff --git a/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc b/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc
index f67ec2de0dd66de204c78e21607008e1e447e93e..5fbadeef78523aebb7a94f2ca5f8091cdf21392d 100644
--- a/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc
+++ b/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc
@@ -109,6 +109,7 @@ void ManifestUpgradeDetectorFetcher::DidFinishLoad(
ShortcutHelper::GetIdealHomescreenIconSizeInDp();
params.minimum_icon_size_in_dp =
ShortcutHelper::GetMinimumHomescreenIconSizeInDp();
+ params.check_installable = true;
params.fetch_valid_icon = true;
InstallableManager::CreateForWebContents(web_contents());
InstallableManager* installable_manager =
@@ -132,6 +133,11 @@ void ManifestUpgradeDetectorFetcher::OnDidGetInstallableData(
if (data.manifest.IsEmpty() || web_manifest_url_ != data.manifest_url)
return;
+ // TODO(pkotwicz): Tell Java side that the Web Manifest was fetched but the
+ // Web Manifest is not WebAPK-compatible. (http://crbug.com/639536)
+ if (!data.is_installable)
+ return;
+
ShortcutInfo info(GURL::EmptyGURL());
info.UpdateFromManifest(data.manifest);
info.manifest_url = data.manifest_url;

Powered by Google App Engine
This is Rietveld 408576698