chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h - Issue 2262583002: Do not request upgrade if Web Manifest is no longer WebAPK-capable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h

Issue 2262583002: Do not request upgrade if Web Manifest is no longer WebAPK-capable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java ('k') | chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc » ('j') | chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h

diff --git a/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h b/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h

index 7d15aebb733dfc49b920b797b28e0d0ded01fe98..8fe800ae6b8ab58c06a20e3dd1b371dfbeb883c7 100644

--- a/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h

+++ b/chrome/browser/android/webapk/manifest_upgrade_detector_fetcher.h

@@ -58,7 +58,9 @@ class ManifestUpgradeDetectorFetcher : public content::WebContentsObserver {

// Called once the installable data has been fetched.

void OnDidGetInstallableData(const InstallableData& installable_data);

- void OnDataAvailable(const ShortcutInfo& info, const SkBitmap& icon);

+ void OnDataAvailable(bool is_installable,

+ const ShortcutInfo& info,

+ const SkBitmap& icon);

// Points to the Java object.

base::android::ScopedJavaGlobalRef<jobject> java_ref_;