Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Issue 2262543002: DevTools: Profiler domain refactoring: encode timestamps as deltas. (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
paulirish, dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Profiler domain refactoring: encode timestamps as deltas. The CL makes CPUProfile encode sample timestamps as deltas, which makes the representation more compact. startTime and endTime are represented in microseconds rather than seconds. BUG=635947 Committed: https://crrev.com/68666c0876081db75338384d7b76f0b5fb84473e Cr-Commit-Position: refs/heads/master@{#413332}

Patch Set 1 #

Total comments: 2

Patch Set 2 : 4 landing #

Messages

Total messages: 24 (14 generated)
alph
4 years, 4 months ago (2016-08-18 22:16:30 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2262543002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js (right): https://codereview.chromium.org/2262543002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js#newcode53 third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js:53: this._compatibilityConversionHeadToNodes(profile); Let's call this in |isLegacyFormat| block?
4 years, 4 months ago (2016-08-19 00:45:12 UTC) #6
alph
https://codereview.chromium.org/2262543002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js (right): https://codereview.chromium.org/2262543002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js#newcode53 third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js:53: this._compatibilityConversionHeadToNodes(profile); On 2016/08/19 00:45:12, dgozman wrote: > Let's call ...
4 years, 4 months ago (2016-08-20 01:51:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262543002/20001
4 years, 4 months ago (2016-08-20 01:55:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/283634)
4 years, 4 months ago (2016-08-20 03:12:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262543002/20001
4 years, 4 months ago (2016-08-20 05:05:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/126468)
4 years, 4 months ago (2016-08-20 06:20:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262543002/20001
4 years, 4 months ago (2016-08-20 09:55:39 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-20 10:26:33 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 10:28:13 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/68666c0876081db75338384d7b76f0b5fb84473e
Cr-Commit-Position: refs/heads/master@{#413332}

Powered by Google App Engine
This is Rietveld 408576698