Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2262533002: Stop using GrTexture::get/setCustomData in Canvas2DLayerBridge (Closed)

Created:
4 years, 4 months ago by Justin Novosad
Modified:
4 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop using GrTexture::get/setCustomData in Canvas2DLayerBridge Canvas2DLayerBridge was using custom data to cache mailbox names associated with recycled textures managed by skia. This helped prevent leaking mailboxes. This CL uses a different approach that consists in disassociating mailboxes to prevent the mailbox leak. The goal is to allow the skia team to proceed with the deprecation of texture custom data attachments. BUG=632722 Committed: https://crrev.com/645b3cc4697033ab68738dc68d9dfd8db200c008 Cr-Commit-Position: refs/heads/master@{#413129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Justin Novosad
PTAL
4 years, 4 months ago (2016-08-18 22:08:08 UTC) #4
piman
lgtm
4 years, 4 months ago (2016-08-18 22:23:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262533002/1
4 years, 4 months ago (2016-08-19 13:55:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 13:58:27 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 14:02:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/645b3cc4697033ab68738dc68d9dfd8db200c008
Cr-Commit-Position: refs/heads/master@{#413129}

Powered by Google App Engine
This is Rietveld 408576698