Issue 226253003: Change SkDecodingImageGenerator to hide implementation details.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226253003: Change SkDecodingImageGenerator to hide implementation details. (Closed)

Created:
6 years, 8 months ago by hal.canary

Modified:
6 years, 8 months ago

Reviewers:
scroggo, reed2

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Change SkDecodingImageGenerator to hide implementation details. Motivation: A later CL will move SkDecodingImageGenerator into include/ for Android to use. Committed: http://code.google.com/p/skia/source/detail?r=14066

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -63 lines)			Patch
	M	src/images/SkDecodingImageGenerator.h	View		2 chunks	+4 lines, -28 lines	1 comment	Download
	M	src/images/SkDecodingImageGenerator.cpp	View		6 chunks	+62 lines, -35 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/226253003/1

6 years, 8 months ago (2014-04-04 20:12:49 UTC) #4

reed2

6 years, 8 months ago (2014-04-04 20:59:51 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/226253003/diff/1/src/images/SkDecodingImageGe...
File src/images/SkDecodingImageGenerator.h (right):

https://codereview.chromium.org/226253003/diff/1/src/images/SkDecodingImageGe...
src/images/SkDecodingImageGenerator.h:21: namespace SkDecodingImageGenerator {
Why namespace instead of class? Other examples in skia use class for this (e.g.
SkGradientShader)

Expand Messages | Collapse Messages