Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2262513002: [MERGE to 53] Add ERR_CERTIFICATE_TRANSPARENCY_REQUIRED to error report cert errors (Closed)

Created:
4 years, 4 months ago by felt
Modified:
4 years, 4 months ago
Reviewers:
estark
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Add ERR_CERTIFICATE_TRANSPARENCY_REQUIRED to error report cert errors I noticed that ERR_CERTIFICATE_TRANSPARENCY_REQUIRED wasn't being added to cert reports, so this fixes that. BUG=637970 TBR=estark@chromium.org Review-Url: https://codereview.chromium.org/2232813003 Cr-Commit-Position: refs/heads/master@{#412117} (cherry picked from commit d36933b3152a7b41c6909d0209687df020e734c9) Committed: https://chromium.googlesource.com/chromium/src/+/e2e8dcde43672395638fde33a641567aaf65e54b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M components/certificate_reporting/cert_logger.proto View 1 chunk +1 line, -0 lines 0 comments Download
M components/certificate_reporting/error_report.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/certificate_reporting/error_report_unittest.cc View 9 chunks +32 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
felt
4 years, 4 months ago (2016-08-18 21:50:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2e8dcde43672395638fde33a641567aaf65e54b.

Powered by Google App Engine
This is Rietveld 408576698