Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 22625008: Use TestBrowserThreadBundle in MediaGalleriesPreferences tests. (Closed)

Created:
7 years, 4 months ago by earthdok
Modified:
7 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Lei Zhang, tommycli, Greg Billock, vandebo (ex-Chrome)
Visibility:
Public.

Description

Use TestBrowserThreadBundle in MediaGalleriesPreferences tests. Simplify code and potentially plug a memory leak. BUG=270940 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216926

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed unused include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M chrome/browser/media_galleries/media_galleries_preferences_unittest.cc View 1 4 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
earthdok
ptal
7 years, 4 months ago (2013-08-09 20:12:29 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/22625008/diff/1/chrome/browser/media_galleries/media_galleries_preferences_unittest.cc File chrome/browser/media_galleries/media_galleries_preferences_unittest.cc (right): https://codereview.chromium.org/22625008/diff/1/chrome/browser/media_galleries/media_galleries_preferences_unittest.cc#newcode12 chrome/browser/media_galleries/media_galleries_preferences_unittest.cc:12: #include "base/message_loop/message_loop.h" No longer used -> remove?
7 years, 4 months ago (2013-08-09 21:32:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/22625008/2
7 years, 4 months ago (2013-08-09 22:06:20 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-09 22:41:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/22625008/2
7 years, 4 months ago (2013-08-10 10:05:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=186195
7 years, 4 months ago (2013-08-10 14:04:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/22625008/2
7 years, 4 months ago (2013-08-10 17:37:46 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-12 05:11:14 UTC) #8
Message was sent while issue was closed.
Change committed as 216926

Powered by Google App Engine
This is Rietveld 408576698