native_client_sdk/src/libraries/nacl_io/syscalls/htonl.c - Issue 22625004: Adds htonl, htons, ntohl, and ntohs to newlib

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: native_client_sdk/src/libraries/nacl_io/syscalls/htonl.c

Issue 22625004: Adds htonl, htons, ntohl, and ntohs to newlib (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gethostbyname

Patch Set: Fixed remaining bad casts Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « native_client_sdk/src/libraries/nacl_io/library.dsc ('k') | native_client_sdk/src/libraries/nacl_io/syscalls/htons.c » ('j') | native_client_sdk/src/libraries/nacl_io/syscalls/htons.c » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 /* Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 * Use of this source code is governed by a BSD-style license that can be

	3 * found in the LICENSE file. */

	4

	5 #include "nacl_io/ossocket.h"

	6

	7 #if defined(PROVIDES_SOCKET_API) && !defined(__GLIBC__)

	8

	9 #include <string.h>

	10

	11 inline uint32_t htonl(uint32_t hostlong) {

	12 uint8_t result_bytes[4];

	13 result_bytes[0] = (uint8_t) ((hostlong >> 24) & 0xFF);

	14 result_bytes[1] = (uint8_t) ((hostlong >> 16) & 0xFF);

	15 result_bytes[2] = (uint8_t) ((hostlong >> 8) & 0xFF);

	16 result_bytes[3] = (uint8_t) (hostlong & 0xFF);
	Sam Clegg 2013/08/08 19:34:44 This code is endian depend thought right? I'd rat This code is endian depend thought right? I'd rather see a correct implementation here that works on either endianness. glibc uses "# if __BYTE_ORDER == __BIG_ENDIAN" (would need to find a working equivalent on win32 if we ever compile this library on windows again in the future). Also, I think we can/should avoid the extra function call here and just do it using bitwise operators. This is an example from naclports (glibc-compat/include/machine/endian.h): #define __byte_swap_16(x) \ ( (((x) & 0xff) << 8) \| ((unsigned short)(x) >> 8) ) #define __byte_swap_32(x) \ ( ((x) << 24) \| \ (((x) << 8) & 0x00ff0000) \| \ (((x) >> 8) & 0x0000ff00) \| \ ((x) >> 24) ) (Although it looks like that final left shift needs to be masked or cast to unsigned!)
	17

	18 uint32_t result;

	19 memcpy(&result, result_bytes, 4);

	20 return result;

	21 }

	22

	23 #endif /* defined(PROVIDES_SOCKET_API) && !defined(__GLIBC__) */

OLD	NEW