Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2262483003: Worklet: Move common worklet code from modules/worklet to core/workers (Closed)

Created:
4 years, 4 months ago by nhiroki
Modified:
4 years, 4 months ago
Reviewers:
haraken, ikilpatrick
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, falken, blink-worker-reviews_chromium.org, darktears, blink-reviews, horo+watch_chromium.org, kinuko+worker_chromium.org, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worklet: Move common worklet code from modules/worklet to core/workers After ThreadedWorklet is introduced, worklet code gets more tied up with worker code, so it'd be reasonable that they are located in the same directory. BUG=567358 Committed: https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66 Cr-Commit-Position: refs/heads/master@{#413413}

Patch Set 1 #

Patch Set 2 : fix gypi order #

Patch Set 3 : remove modules/worklet directory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -291 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 3 chunks +6 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScopeProxy.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/Worklet.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/Worklet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/Worklet.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/WorkletScriptLoader.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/workers/WorkletScriptLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintWorklet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
D third_party/WebKit/Source/modules/worklet/DEPS View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/Source/modules/worklet/OWNERS View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/modules/worklet/ThreadedWorkletGlobalScopeProxy.h View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/Source/modules/worklet/Worklet.h View 1 chunk +0 lines, -52 lines 0 comments Download
D third_party/WebKit/Source/modules/worklet/Worklet.cpp View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/Source/modules/worklet/Worklet.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.h View 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/Source/modules/worklet/WorkletScriptLoader.cpp View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
nhiroki
ikilpatrick@, can you review this? I think this doesn't heavily conflict with your CL: https://codereview.chromium.org/2254593002/ ...
4 years, 4 months ago (2016-08-19 03:45:17 UTC) #6
ikilpatrick
lgtm Thanks for this!
4 years, 4 months ago (2016-08-19 16:40:56 UTC) #9
nhiroki
+haraken, can you review core.gypi? Thanks!
4 years, 4 months ago (2016-08-22 00:00:18 UTC) #11
haraken
LGTM
4 years, 4 months ago (2016-08-22 00:55:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262483003/40001
4 years, 4 months ago (2016-08-22 01:22:54 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/277923)
4 years, 4 months ago (2016-08-22 05:10:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262483003/40001
4 years, 4 months ago (2016-08-22 05:11:48 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-22 06:46:10 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 06:49:38 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6142503bf4368e18be7181bf96af791ca57d8c66
Cr-Commit-Position: refs/heads/master@{#413413}

Powered by Google App Engine
This is Rietveld 408576698