fpdfsdk/javascript/app.h - Issue 2262473002: Introduce pdfium::FakeUniquePtr for keys to sets of unique ptrs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/javascript/app.h

Issue 2262473002: Introduce pdfium::FakeUniquePtr for keys to sets of unique ptrs. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/javascript/app.h

diff --git a/fpdfsdk/javascript/app.h b/fpdfsdk/javascript/app.h

index 911d86586ad5b3dff412ffee59dbeafdfe20630d..8fd78d9dbc23ab62370f806e6dc5ff42c4211047 100644

--- a/fpdfsdk/javascript/app.h

+++ b/fpdfsdk/javascript/app.h

@@ -7,8 +7,8 @@

#ifndef FPDFSDK_JAVASCRIPT_APP_H_

#define FPDFSDK_JAVASCRIPT_APP_H_

-#include <map>

#include <memory>

+#include <set>

Lei Zhang 2016/08/19 05:53:12 Can we go with unordered_set?

Tom Sepez 2016/08/19 17:20:52 Done.

#include <vector>

#include "fpdfsdk/javascript/JS_Define.h"

@@ -166,7 +166,7 @@ class app : public CJS_EmbedObj {

bool m_bCalculate;

bool m_bRuntimeHighLight;

- std::map<GlobalTimer*, std::unique_ptr<GlobalTimer>> m_Timers;

+ std::set<std::unique_ptr<GlobalTimer>> m_Timers;

};

class CJS_App : public CJS_Object {

« no previous file with comments | « no previous file | fpdfsdk/javascript/app.cpp » ('j') | third_party/base/stl_util.h » ('J')