Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2262453002: Cleanup (Closed)

Created:
4 years, 4 months ago by Peter Wen
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, sadrul, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, jam, gcasto+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, khushalsagar+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, kalyank, jbudorick+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, lizeb+watch-custom-tabs_chromium.org, jochen+watch_chromium.org, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, android-webview-reviews_chromium.org, mikecase+watch_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup BUG=

Patch Set 1 #

Patch Set 2 : Fix cronet. #

Patch Set 3 : Fix cronet. #

Patch Set 4 : Rebase. #

Patch Set 5 : Fix stuff. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -118 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M base/android/java/src/org/chromium/base/PathUtils.java View 9 chunks +17 lines, -25 lines 0 comments Download
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/ModernLinker.java View 1 chunk +1 line, -1 line 0 comments Download
M base/android/path_utils.cc View 6 chunks +6 lines, -10 lines 0 comments Download
M blimp/client/app/android/java/src/org/chromium/blimp/BlimpApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetTestBase.java View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 1 2 3 4 16 chunks +24 lines, -33 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/DiskStorageTest.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java View 1 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/src/org/chromium/net/TestFilesInstaller.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/invalidation/impl/android/javatests/src/org/chromium/components/invalidation/InvalidationClientServiceTest.java View 1 chunk +1 line, -1 line 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java View 1 2 3 4 2 chunks +3 lines, -5 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/NativeLibraryTestBase.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java View 1 2 3 4 2 chunks +3 lines, -5 lines 0 comments Download
M content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java View 1 2 3 4 2 chunks +3 lines, -5 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (21 generated)
Peter Wen
The CQ bit was checked by wnwen@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-18 21:10:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262453002/1
4 years, 4 months ago (2016-08-18 21:11:13 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-18 21:34:37 UTC) #3
commit-bot: I haz the power
Dry run: Exceeded global retry quota
4 years, 4 months ago (2016-08-18 21:34:38 UTC) #4
Peter Wen
The CQ bit was checked by wnwen@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-18 21:52:05 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262453002/20001
4 years, 4 months ago (2016-08-18 21:52:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-18 22:22:08 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/125393)
4 years, 4 months ago (2016-08-18 22:22:09 UTC) #8
Peter Wen
The CQ bit was checked by wnwen@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-18 22:32:37 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262453002/40001
4 years, 4 months ago (2016-08-18 22:33:22 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-18 22:36:41 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/54737) ios-simulator on ...
4 years, 4 months ago (2016-08-18 22:36:42 UTC) #12
Peter Wen
The CQ bit was checked by wnwen@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-18 23:01:42 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262453002/60001
4 years, 4 months ago (2016-08-18 23:02:57 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-18 23:33:26 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/115032) linux_android_rel_ng on ...
4 years, 4 months ago (2016-08-18 23:33:27 UTC) #16
Peter Wen
The CQ bit was checked by wnwen@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-22 19:34:48 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262453002/80001
4 years, 4 months ago (2016-08-22 19:35:44 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-22 21:37:39 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/250631)
4 years, 4 months ago (2016-08-22 21:37:40 UTC) #20
Peter Wen
4 years, 3 months ago (2016-09-08 17:12:21 UTC) #21 
Description was changed from

==========
Cleanup

BUG=
==========

to

==========
Cleanup

BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698