Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2262443002: Adding new shared config for Chrome and WebView (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
Yaron, agrieve, Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding new shared config for Chrome and WebView BUG=619937 Committed: https://crrev.com/244a16046a4ffa8b9e0ec6b8a3ae79f4f74475cb Cr-Commit-Position: refs/heads/master@{#413154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -66 lines) Patch
M android_webview/apk/java/proguard.flags View 2 chunks +0 lines, -33 lines 0 comments Download
M android_webview/system_webview_apk_tmpl.gni View 1 chunk +1 line, -0 lines 0 comments Download
A base/android/release_proguard_config.flags View 1 chunk +32 lines, -0 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/proguard.flags View 2 chunks +0 lines, -33 lines 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
smaier
yfriedman@chromium.org: Please review changes in chrome, base torne@chromium.org: Please review changes in webview, base Let ...
4 years, 4 months ago (2016-08-18 17:35:35 UTC) #2
Torne
LGTM
4 years, 4 months ago (2016-08-19 10:56:24 UTC) #4
Yaron
lgtm
4 years, 4 months ago (2016-08-19 13:36:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2262443002/1
4 years, 4 months ago (2016-08-19 13:38:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 15:55:05 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 15:57:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/244a16046a4ffa8b9e0ec6b8a3ae79f4f74475cb
Cr-Commit-Position: refs/heads/master@{#413154}

Powered by Google App Engine
This is Rietveld 408576698